Skip to content

Conversation

@MarkWolters
Copy link
Contributor

This PR fixes a bug that was introduced by PR542 - On Disk Graph Index Parallelization. In the original PR the new parallel writing implementation would overwrite anything that had been already written through calls to writeInline when the write() method of the OnDiskGraphIndexWriter was called. In this PR the logic has been updated to read the existing data into the buffer prior to flushing writes to disk, preserving the contents.

@github-actions
Copy link
Contributor

Before you submit for review:

  • Does your PR follow guidelines from CONTRIBUTIONS.md?
  • Did you summarize what this PR does clearly and concisely?
  • Did you include performance data for changes which may be performance impacting?
  • Did you include useful docs for any user-facing changes or features?
  • Did you include useful javadocs for developer oriented changes, explaining new concepts or key changes?
  • Did you trigger and review regression testing results against the base branch via Run Bench Main?
  • Did you adhere to the code formatting guidelines (TBD)
  • Did you group your changes for easy review, providing meaningful descriptions for each commit?
  • Did you ensure that all files contain the correct copyright header?

If you did not complete any of these, then please explain below.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants