Skip to content

[QC] Fix for (GuardLogStatement) Logger calls should be surrounded by log level guards. #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[QC] Fix for (GuardLogStatement) Logger calls should be surrounded by log level guards. #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/main/java/io/harness/cf/client/api/InnerClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ public InnerClient(@NonNull final String sdkKey, @NonNull final BaseConfig optio
}

public InnerClient(@NonNull final Connector connector) {
this(connector, BaseConfig.builder().build());
this(connector, BaseConfig.builder().build());
}

public InnerClient(@NonNull Connector connector, @NonNull final BaseConfig options) {
Expand All @@ -81,7 +81,9 @@ public InnerClient(@NonNull Connector connector, @NonNull final BaseConfig optio

protected void setUp(@NonNull final Connector connector, @NonNull final BaseConfig options) {
this.options = options;
log.info("Starting SDK client with configuration: {}", this.options);
if (log.isInfoEnabled()) {
log.info("Starting SDK client with configuration: {}", this.options);
}
this.connector = connector;
this.connector.setOnUnauthorized(this::onUnauthorized);

Expand Down