[WIP] Add Moon+ Reader support #23
Conversation
This adds support for importing annotations from a Moon+ Reader backup file (.mrpro). .mrpro is just a zip file, that contains a SQLite3 databse inside. This extracts the annotations from there, and imports them with the Annotations plugin.
There was a problem hiding this comment.
I wonder if there isn't an easier way to get access to the Moon Reader database. Doesn't it store it somewhere on the mounted USB disk, as some Android apps do?
The https://www.mobileread.com/forums/showthread.php?t=328879&highlight=moon+reader+database thread suggests that it might be located under the android/data folder or similar.
It appears to be in |
I see. Then parsing backup is better than nothing for sure 😄 . |
This introduces a default bg and fg color setting, and also allows specifying an HTML color as well as the existing hard coded shades.
This is causing Calibre to crash on my production instance... but not my dev environment. Needs investigating This reverts commit 393fd77.
|
I moved the title to WIP since this isn't ready to review. After the initial set of comments, I realized I should break out some additional features into additional PR's. Since this is dependent on those, I would wait to look at anything here until I rebase this one after those land. |
You can convert a PR into a draft. More info about this at https://github.blog/changelog/2020-04-08-convert-pull-request-to-draft/ . |
|
Sure, I made it a draft if that's somehow better for you than [WIP] title 🤷 |
|
It's been a month, this repo despite claims to the contrary doesn't seem to be actively maintained with just a few commits per year, and little activity on my forum questions. |
|
@stbenjam , I completely understand you. Please be patient. We're not in a hurry here with @davidfor being very occupied with other projects and not being able to timely review any PR coming in. I'm glad, that you're able to implement a Moon+ Reader integration, that works for you. Please don't let it disappear and not make any other Moon+ Reader + Calibre user happy. It will be reviewed eventually I guess. |
|
Nah, I'm good. I'm busy too. |
|
Since you deleted the PR associated branches the GitHub also auto-closed all PRs. If that wasn't intentional please restore them. |
|
@stbenjam I'm not good at coding. And I have not got your branch on time. If convenient, can you share the new calibre-annotations plugin that you show in this page which support Moon+ Reader？I need it very much . Thanks a lot. |
|
@stbenjam: This repository is maintained at exactly the rate it is needed to. Yes, there are few commits per year. But, that is because there are very few changes that have been needed. For your change, you had perfectly bad timing. Some work and personal commitments hit me at that time. That left no time and no energy for anything else. Those extended for longer than expected and things that are unimportant to me, which unfortunately includes this plugin, went by the wayside. When I did find the time, and I admit, remembered it needed to be done, I discovered the pull request had been closed a few days before. That was a couple of weeks ago, and I should have posted this then. But, honestly, if you have that little interest that you actually withdrew the pull request, I figured my time was better spent doing something else. Such as reading a book. If you do want this done, please open another pull request. I will try an look at it over the weekend after you do that. |
|
@stbenjam I am very interested to try your plugin as it would form a key component in a workflow concept. I hope to see it implemented soon. |
|
The branches are restored if someone wants to pick up working on them. I'm sympathetic to being busy, but I also have plenty of experience in open source and attracting contributors requires at least some acknowledgement and communication about what to expect. I can't go months between reviews, given the loss of context between each round. No hard feelings if you can't keep up on what needs to be done in the project, but I'm incredulous to call it a maintained project when there's multiple PR's still open on this repo without a single comment. |
|
You said, "doesn't seem to be actively maintained with just a few commits per year". That was what I was referring to. The number of commits each year is meaningless because there were no changes needed. Am I supposed to make up things to do? I suppose that I should have posted on these PRs something. But, when they came in, I planned to look at them in a few days, probably over the next weekend. If that had happened, everything would have gone through with no issues. Unfortunately, other things came up which meant I was not able to and also didn't think to post anything else. In any case, my intention is to look at these this weekend. Hopefully no one breaks anything at work. |
|
Great to see this progressing. Thanks both 👍 |
|
I have finally found time to read through this and have a lot of problems with it. There are changes in it that have nothing to do with adding Moon+ Reader support. Some of that is in a pull request that has been merged. But, some are changes that not needed for this and may cause issues elsewhere. There is a comment about rebasing after the pull requests for the file chooser and colour support is done. These have been merged. Could you update this and resubmit? |
5 participants
Note: hold off on reviewing this more until some of the separate features I've extracted from this are merged:
This adds support for importing annotations from a Moon+ Reader backup
file (.mrpro).
This extracts the annotations from there. Feedback welcome, my python is pretty out of date.
Screenshots:
Fixes #19