Skip to content

add: Mock SPI errors #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

add: Mock SPI errors #131

wants to merge 2 commits into from

Conversation

@2bndy5
Copy link

@2bndy5 2bndy5 commented Apr 25, 2025 •
edited
Loading

resolves #128

Please review diligently as I'm not overly familiar with this crate's code.

@2bndy5 2bndy5 mentioned this pull request Apr 25, 2025
Closed
@2bndy5 2bndy5 changed the title Mock SPI errors add: Mock SPI errors Apr 25, 2025
@2bndy5 2bndy5 mentioned this pull request May 2, 2025
Merged
@benjaminschlegel87
Copy link

benjaminschlegel87 commented May 20, 2025

I stumbled across the same problem today and was quite pleased to this was already implemented. As a disclaimer: I got general embedded experience but in terms of idomatic rust I am quite a beginner. Still I reviewed your implementation and the tests. From my POV this looks good and I would have implemented it equally. Would like to see this upstream

simonsso
simonsso approved these changes Oct 22, 2025
View reviewed changes
Copy link
Contributor

@simonsso simonsso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good, same kind of implementations as used in I2C.

@simonsso
Copy link
Contributor

simonsso commented Oct 22, 2025

Ok then all we need is @dbrgn to get some time and merge this.

@2bndy5
Copy link
Author

2bndy5 commented Oct 22, 2025

It's been pending admin review for over half a year. I'm not holding my breathe. Instead, I've been using this from my fork's dev branch (cherry picked commits from this branch and another PR also pending review).

@simonsso
Copy link
Contributor

simonsso commented Oct 23, 2025

It's been pending admin review for over half a year. I'm not holding my breathe. Instead, I've been using this from my fork's dev branch (cherry picked commits from this branch and another PR also pending review).

Yes I saw that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@simonsso simonsso simonsso approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

add with_error() for SPI Transaction

3 participants

@2bndy5 @benjaminschlegel87 @simonsso