Skip to content

Add a warning when regenerating the lockfile for packages and there is a hash mismatch #11914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add a warning when regenerating the lockfile for packages and there is a hash mismatch #11914

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions core/dbt/events/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1517,6 +1517,14 @@ def message(self) -> str:
return f"Found duplicate package in packages.yml, removing: {self.removed_package}"


class DepsLockfileRegenerating(WarnLevel):
def code(self):
return "M034"

def message(self) -> str:
return f"Package lockfile is out of sync with packages.yml. Regenerating lockfile at: {self.lock_filepath}"


class DepsScrubbedPackageName(WarnLevel):
def code(self):
return "M035"
Expand Down
2 changes: 2 additions & 0 deletions core/dbt/task/deps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
DepsFoundDuplicatePackage,
DepsInstallInfo,
DepsListSubdirectory,
DepsLockfileRegenerating,
DepsLockUpdating,
DepsNoPackagesFound,
DepsNotifyUpdatesAvailable,
Expand Down Expand Up @@ -220,6 +221,7 @@ def run(self) -> None:
current_hash = _create_sha1_hash(self.project.packages.packages)
previous_hash = load_yml_dict(lock_file_path).get(PACKAGE_LOCK_HASH_KEY, None)
if previous_hash != current_hash:
fire_event(DepsLockfileRegenerating(lock_filepath=lock_file_path))
self.lock()

# Early return when 'dbt deps --lock'
Expand Down
Loading