Skip to content

Conversation

@aksestok
Copy link
Contributor

Resolves #11882.

I couldn't for the life of me get flake8 or mypy to run in pre-commit, but they did run successfully outside of the pre-commit context.

Problem

dbt Fusion users can't set quoting.snowflake_ignore_case in their project files if they also use dbt core.

Solution

Implements the proposed solution in #11882.

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@aksestok aksestok requested a review from a team as a code owner August 21, 2025 07:33
@cla-bot cla-bot bot added the cla:yes label Aug 21, 2025
@github-actions github-actions bot added the community This PR is from a community member label Aug 21, 2025
@aksestok aksestok force-pushed the add-snowflake-ignore-case branch from 419d082 to 0cbb6a5 Compare August 21, 2025 07:47
@codecov
Copy link

codecov bot commented Sep 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.91%. Comparing base (9bc7333) to head (0f05fdf).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11942      +/-   ##
==========================================
+ Coverage   91.85%   91.91%   +0.05%     
==========================================
  Files         199      199              
  Lines       24363    24404      +41     
==========================================
+ Hits        22379    22431      +52     
+ Misses       1984     1973      -11     
Flag Coverage Δ
integration 88.74% <100.00%> (+0.02%) ⬆️
unit 65.32% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 65.32% <100.00%> (+0.06%) ⬆️
Integration Tests 88.74% <100.00%> (+0.02%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

MichelleArk
MichelleArk previously approved these changes Sep 3, 2025
Copy link
Contributor

@MichelleArk MichelleArk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I've validated this fix locally.

Only note is to revert the changes to the jsonschemas prior to merging to avoid merge conflicts.

@MichelleArk MichelleArk merged commit 15010f1 into dbt-labs:main Sep 3, 2025
53 of 56 checks passed
MichelleArk pushed a commit that referenced this pull request Sep 3, 2025
@aksestok aksestok deleted the add-snowflake-ignore-case branch September 4, 2025 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla:yes community This PR is from a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] No-op when project-level quoting.snowflake_ignore_case is set

2 participants