-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Support quoting.snowflake_ignore_case
#11942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
419d082 to
0cbb6a5
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11942 +/- ##
==========================================
+ Coverage 91.85% 91.91% +0.05%
==========================================
Files 199 199
Lines 24363 24404 +41
==========================================
+ Hits 22379 22431 +52
+ Misses 1984 1973 -11
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
MichelleArk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I've validated this fix locally.
Only note is to revert the changes to the jsonschemas prior to merging to avoid merge conflicts.
Resolves #11882.
I couldn't for the life of me get
flake8ormypyto run in pre-commit, but they did run successfully outside of the pre-commit context.Problem
dbt Fusion users can't set
quoting.snowflake_ignore_casein their project files if they also use dbt core.Solution
Implements the proposed solution in #11882.
Checklist