Skip to content

Conversation

@gomain
Copy link

@gomain gomain commented Dec 23, 2022

Thank You for the amazing work put into creating this tool.

However, I had to fork this repo in order to make some tweaks to suit my use case. Here are the changes made:

Emit imports with import type ... when importing only types

This is to comply with my tsconfig option "importsNotUsedAsValues": "error".

Append .js to imported module

To comply with ESM.

Expand glob patterns internally

So that I can write a

  "scripts": { 
    "generate": "wsdl-tsconfig './wsdl/**/*.wsdl' -o ./generated"
  }

Support wsdl URI as either path or URL

Such that the build is up-to-date with the live service without having redownload the wsdls. Build/tests would break when service makes breaking changes.

Pre-configure createClientAsync with provided URI

The wsdl URI should only have to be provided once. The exported createClientAsync still takes the remaining parameters which could conflict with the parsing - room for improvement here.


I ended up not utilizing glob matching and build against live wsdls.

This PR is only intended to start a discussion on whether these features are general useful. If so, we may discuss on extracting some changes to own PR, adding configuration flags, testing, implementation review etc..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant