-
Notifications
You must be signed in to change notification settings - Fork 163
MVP Review: Nameless(Group C) #310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jaltamiranobello
wants to merge
507
commits into
deadroxy:master
Choose a base branch
from
jaltamiranobello:prototype
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e current instance varaible of station which displays the bike inventory
Completed Stations and Bikes
…ctionality if needed
…s inventory views
… inventory from the home page
…rom the account & settings page
…view after viewing the stations
…8) is error arises for u guys check if u have double of this gem
…show function now works, but plz keep in mine you can't do trips/show as this page is being rendered in the create function
…lo/valetbike into integrate_payment
…se to do, also i added the edit and update crud methods - fernanda you can update these two functions however you like. I didnt finish them so they have bugs
… connect it with the stripe functionality
Payments New, Trip Create Page, Trip Show Page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting Up Dev Environment
MVP Functionality
Our MVP has the necessary components for a bike renting service. First, it provides clear and ample information to the user through clear design. It supports the creation, modification, and deletion of user accounts. It allows users to rent bikes through the initial station finding service, then displays the stations, the bikes available at a given station, the checkout confirmation, and the payment with Stripe. It also allows users to view their trip history.
*User Functionality Credits: Devise
*Payment Functionality Credits: Stripe
*Search Station Functionality Credits: GeoCoder
Summary of Changes
Since our prototype we have overhauled the entire rental process: user can now view a list of stations and their inventory, search for nearby stations, select a station from this list to rent from, select a bike from the available inventory of the station, start a trip and instantiate it in the trip model, end a trip at a selected return station, calculate the cost of a trip, and process a payment for a specific trip. Additionally, we added the ability to review your trip history, an interactive FAQ section, a “Team” page, and a contact mechanism. We also created and styled views to make it possible to access all of the functionality in a clear straightforward way.
Recommended Walkthrough
The opening screen of our MVP is a welcome page which provides users with enough information about the service to decide if they want to create an account. From this page you can log in with a pre-existing account, or get started and create a new account.
The sign up page includes a form which takes in a first and last name, email, two password fields that must match. If any fields are left blank, the passwords don’t match, the email is already associated with a user, or the email is not in the format of a valid email you will be prompted with an error message that tells what to edit. When all fields meet the success criteria, a new user is created with that information and you are logged in.
The log in page contains a similar form prompting you for an email and password. If the email is associated with a known user and the password matches, you will be logged in. Otherwise, “Invalid Email or password” will be displayed.
Once logged in, you will see the main page featuring a header containing the Valetbike logo and, on the far right, “Rent a Bike,” “Trip History,” and “My Account” options. Below, we see a static map and a message to “Find A Station Near You.” This is helpful to find the stations before you rent a bike. Try typing in “Smith College” or “100 Elm Street, Northampton, MA 01063” (the location must be within Google Maps – a limitation) and then clicking “Search.” If the address was recognized, a list of stations will be displayed, both as markers on the map and as text below the search bar. Otherwise, you will see text saying “No nearby stations found.” On the footer of the page, we have a button to return Home that remains consistent across all pages, a button to bring you to a “Meet the Team” page with a photo and our bios, and a link to a contact email.
From here you can select the “Rent a Bike” button on the top menu to start the bike checkout process. On this page you will find a list of all stations in our system, including their name and the number of bikes currently available, as well as a “RETURN TO MAIN PAGE” button. For each station you will also see a “View Bikes” button. Selecting any station will take you to a new page where all the available bikes at your selected station are displayed. On this page is also a “Back to Stations” button, in case you want to change your station. For each bike available you will see a “Rent Bike” button, which will bring you to a confirmation page. Here you should see the station and bike you selected. If the station or bike is not what you expected, use the “Change Station” button or “Change Bike” button to update this information. The “Change Station” button will return you to the station selection page, while the “Change Bike” button will prompt you for the bike ID you want directly. Once you’ve confirmed the station and bike information is accurate, select the “Book my Bike” button. This will start your trip and bring you to a page displaying your trip information.
On the confirmation page you will see the start time of your trip, as well as the Trip ID number and your User ID number. Below you will find a button reading “END TRIP”, selecting this button will conclude your trip and return you to the list of stations. Here you will be prompted to select your return station. You will then be redirected to the payments page, where you will see the total cost of your trip based on the ride time, and a button reading “CLICK HERE TO PAY” (a trip should cost $0.25 per hour, but as Stripe does not accept payments of less than 50 cents, your trip will most likely be automatically bumped up to 51 cents). Selecting this button will redirect you to Stripe. You will be prompted to enter your email address, card details, and phone number. You will also have the option to save this information for a faster checkout next time. To experience this step without an actual transaction input test card number 4242 4242 4242 4242 followed by any future date, and any 3 digits in the CVC field. Once your transaction is successful you will see a confirmation screen, selecting the “GO BACK” button here will return you to the main page (the main bug in the project is that, when you spend too much time at the checkout, we believe that Devise un-sets the current user and you are logged out when you return to the main page. However, the majority of the time, you retain your logged-in status after checking out).
Selecting “My Account” from the header will bring you to a new page where you can see your profile information and update your first and last names, email, or password, as long as you confirm your identity with your current password. If you incorrectly enter your current password you will see an error message “Current password is invalid” and your changes will not save. You can also “Delete Account” or “Logout.” The “Logout” button, underneath the “My Account” button in the header, will also log you out and return to the welcome page. The “Trip History button” in the header will take you to your personal trip history. If you select “Trip History” you should see the trip you just took displayed with the Trip ID, Start Station, End Station, Bike ID, and the start time of the rental. As you take more trips with Valet Bike you will be able to see them here.