-
Notifications
You must be signed in to change notification settings - Fork 9
Bump decidim to 0.31.0.rc2 #152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
72d7611 to
8e1f755
Compare
andreslucena
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you check my feedback please? Thanks
andreslucena
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to change to 22.14.0: .node-version. I see that's missing from the notes, can you add it please? https://github.com/decidim/decidim/releases/tag/v0.31.0.rc1 (you can check out older versions updates of Node to copypaste)
Also while we're on it, related to the notes, can you remove these sections from there?
I have changed the node version here, I have patched the release notes. |
27e1f6b to
742f6ee
Compare
andreslucena
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (again!)
The main differences that I see are:
- the change of amazon/s3 in ActiveStorage: we should be aware if other installations have this problem or if its something specific to Metadecidim
- the
decidimomniauth: I'll present a PR at https://github.com/decidim/omniauth-decidim to update instructions to latest version (i.e. not using secrets)
I think these aren't blockers. @fblupi do you want to give a look to this and deploy if everything seems OK?
Done at decidim/omniauth-decidim#9 |
This PR upgrades decidim version to 0.31.o.rc1 to metadecidim.
Commands that needs to be ran