Skip to content

Move to go webhooks #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 31 commits into
base: main
Choose a base branch
from
Open

Move to go webhooks #90

wants to merge 31 commits into from

Conversation

duckhawk
Copy link
Member

@duckhawk duckhawk commented Apr 23, 2025

Description

Ensure webhooks are up-to-date, rewrite several python-based webhooks to golang

Why do we need it, and what problem does it solve?

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • [ x] Changes were tested in the Kubernetes cluster manually.

Signed-off-by: Nikolay Demchuk <[email protected]>
@duckhawk duckhawk added the enhancement New feature or request label Apr 23, 2025
@duckhawk duckhawk requested review from AleksZimin and astef April 23, 2025 02:38
NikolayDemchuk and others added 23 commits April 28, 2025 18:33
Signed-off-by: Nikolay Demchuk <[email protected]>
Signed-off-by: Nikolay Demchuk <[email protected]>
Signed-off-by: Nikolay Demchuk <[email protected]>
Signed-off-by: Nikolay Demchuk <[email protected]>
Signed-off-by: Nikolay Demchuk <[email protected]>
Signed-off-by: Nikolay Demchuk <[email protected]>
Signed-off-by: Nikolay Demchuk <[email protected]>
Signed-off-by: Nikolay Demchuk <[email protected]>
Signed-off-by: Nikolay Demchuk <[email protected]>
Signed-off-by: Nikolay Demchuk <[email protected]>
Signed-off-by: Nikolay Demchuk <[email protected]>
Signed-off-by: Nikolay Demchuk <[email protected]>
Signed-off-by: Aleksandr Stefurishin <[email protected]>
Signed-off-by: Aleksandr Stefurishin <[email protected]>
Signed-off-by: Aleksandr Stefurishin <[email protected]>
Signed-off-by: Aleksandr Stefurishin <[email protected]>
Signed-off-by: Aleksandr Stefurishin <[email protected]>
Signed-off-by: Nikolay Demchuk <[email protected]>
Signed-off-by: Nikolay Demchuk <[email protected]>
Signed-off-by: Nikolay Demchuk <[email protected]>
Signed-off-by: Nikolay Demchuk <[email protected]>
Signed-off-by: Nikolay Demchuk <[email protected]>
Signed-off-by: Nikolay Demchuk <[email protected]>
@NikolayDemchuk NikolayDemchuk marked this pull request as ready for review June 4, 2025 09:35
tlscertificate.GenSelfSignedTLSHookConf{
CN: "csi-nfs-scheduler-extender",
Namespace: ModuleNamespace,
TLSSecretName: "csi-nfs-scheduler-extender-https-certs",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Secret name in python code is scheduler-extender-https-certs

@@ -0,0 +1,254 @@
/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Below code is a modified version of module-sdk, which was added to sds-replicated-volume, because we have several certificates with a common CA there. Since you have only one CA in your case, it should be enough to use what module-sdk already have, it will be much simpler.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried rewriting, caught Helm error

run helm install: check helm values: 3 errors occurred:
* csiNfs.internal.customSchedulerExtenderCert.crt is required
* csiNfs.internal.customSchedulerExtenderCert.key is required
* csiNfs.internal.customSchedulerExtenderCert.ca is required

My point here is to put certificate generaton via module sdk as a different task and bring it to a uniform format across all our relevant modules

Signed-off-by: Nikolay Demchuk <[email protected]>
Signed-off-by: Nikolay Demchuk <[email protected]>
Signed-off-by: Nikolay Demchuk <[email protected]>
Signed-off-by: Nikolay Demchuk <[email protected]>
Signed-off-by: Nikolay Demchuk <[email protected]>
Signed-off-by: Nikolay Demchuk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants