-
Notifications
You must be signed in to change notification settings - Fork 2
feat(vd): Add Exporting
phase and new conditions to VirtualDisk
status
#1256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dd860cd
to
e213ec9
Compare
4367301
to
3edd672
Compare
Exporting
phase and new conditions to VirtualDisk
status
z9r5
previously approved these changes
Jul 21, 2025
f99e0df
to
baa674b
Compare
z9r5
previously approved these changes
Aug 7, 2025
danilrwx
reviewed
Aug 7, 2025
images/virtualization-artifact/pkg/common/annotations/annotations.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Yaroslav Borbat <[email protected]>
4d2f366
to
e0bb634
Compare
danilrwx
approved these changes
Aug 7, 2025
Merged
github-actions bot
pushed a commit
that referenced
this pull request
Aug 8, 2025
…tatus (#1256) This PR introduces a new Exporting phase to the VirtualDisk resource, along with updated InUse and Ready conditions. These changes improve visibility into the state of the disk and prevent accidental usage during data export. Signed-off-by: Yaroslav Borbat <[email protected]>
deckhouse-BOaTswain
added a commit
that referenced
this pull request
Aug 8, 2025
…ualDisk` status (#1328) feat(vd): Add `Exporting` phase and new conditions to `VirtualDisk` status (#1256) This PR introduces a new Exporting phase to the VirtualDisk resource, along with updated InUse and Ready conditions. These changes improve visibility into the state of the disk and prevent accidental usage during data export. Signed-off-by: Yaroslav Borbat <[email protected]> Co-authored-by: Yaroslav Borbat <[email protected]>
Cherry pick PR 1328 to the branch release-0.24 successful! |
This was referenced Aug 11, 2025
loktev-d
pushed a commit
that referenced
this pull request
Aug 14, 2025
…tatus (#1256) This PR introduces a new Exporting phase to the VirtualDisk resource, along with updated InUse and Ready conditions. These changes improve visibility into the state of the disk and prevent accidental usage during data export. Signed-off-by: Yaroslav Borbat <[email protected]> Signed-off-by: Daniil Loktev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new
Exporting
phase to theVirtualDisk
resource, along with updatedInUse
andReady
conditions. These changes improve visibility into the state of the disk and prevent accidental usage during data export.Changes:
Exporting
InUse
condition now includes a new reason:UsedForDataExport
Ready
condition now includes a new reason:Exporting
Purpose:
These updates make it clear when a
VirtualDisk
is actively being exported. While in theExporting
phase:This helps prevent misuse and improves the user experience by providing more precise status information in the
VirtualDisk
resource.Checklist
Changelog entries