Skip to content

feat(vd): Add Exporting phase and new conditions to VirtualDisk status #1256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2025

Conversation

yaroslavborbat
Copy link
Member

@yaroslavborbat yaroslavborbat commented Jul 15, 2025

Description

This PR introduces a new Exporting phase to the VirtualDisk resource, along with updated InUse and Ready conditions. These changes improve visibility into the state of the disk and prevent accidental usage during data export.

Changes:

  • Added new phase: Exporting
  • InUse condition now includes a new reason: UsedForDataExport
  • Ready condition now includes a new reason: Exporting

Purpose:

These updates make it clear when a VirtualDisk is actively being exported. While in the Exporting phase:

  • The disk is not ready for use
  • Any attempt to start a VM using this disk should be blocked
  • Users can clearly understand that the disk is temporarily unavailable due to an ongoing export operation

This helps prevent misuse and improves the user experience by providing more precise status information in the VirtualDisk resource.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: vd
type: feature
summary: Add `Exporting` phase and new conditions to `VirtualDisk` status

@yaroslavborbat yaroslavborbat force-pushed the feat/vd/export-reason branch 2 times, most recently from dd860cd to e213ec9 Compare July 21, 2025 10:34
@yaroslavborbat yaroslavborbat added this to the v0.23.0 milestone Jul 21, 2025
@yaroslavborbat yaroslavborbat marked this pull request as ready for review July 21, 2025 16:58
@yaroslavborbat yaroslavborbat force-pushed the feat/vd/export-reason branch 2 times, most recently from 4367301 to 3edd672 Compare July 21, 2025 17:29
@yaroslavborbat yaroslavborbat changed the title feat(vd): add export reason for VD when PV Lost feat(vd): Add Exporting phase and new conditions to VirtualDisk status Jul 21, 2025
z9r5
z9r5 previously approved these changes Jul 21, 2025
@nevermarine nevermarine modified the milestones: v0.23.0, v0.24.0 Jul 24, 2025
@yaroslavborbat yaroslavborbat marked this pull request as draft July 31, 2025 08:22
@yaroslavborbat yaroslavborbat marked this pull request as ready for review August 7, 2025 08:36
@yaroslavborbat yaroslavborbat force-pushed the feat/vd/export-reason branch 2 times, most recently from f99e0df to baa674b Compare August 7, 2025 08:41
@yaroslavborbat yaroslavborbat requested review from z9r5 and danilrwx August 7, 2025 08:41
z9r5
z9r5 previously approved these changes Aug 7, 2025
Signed-off-by: Yaroslav Borbat <[email protected]>
@yaroslavborbat yaroslavborbat merged commit 7a72d7e into main Aug 7, 2025
21 of 22 checks passed
@yaroslavborbat yaroslavborbat deleted the feat/vd/export-reason branch August 7, 2025 10:52
github-actions bot pushed a commit that referenced this pull request Aug 8, 2025
…tatus (#1256)

This PR introduces a new Exporting phase to the VirtualDisk resource, along with updated InUse and Ready conditions. These changes improve visibility into the state of the disk and prevent accidental usage during data export.
Signed-off-by: Yaroslav Borbat <[email protected]>
deckhouse-BOaTswain added a commit that referenced this pull request Aug 8, 2025
…ualDisk` status (#1328)

feat(vd): Add `Exporting` phase and new conditions to `VirtualDisk` status (#1256)

This PR introduces a new Exporting phase to the VirtualDisk resource, along with updated InUse and Ready conditions. These changes improve visibility into the state of the disk and prevent accidental usage during data export.

Signed-off-by: Yaroslav Borbat <[email protected]>
Co-authored-by: Yaroslav Borbat <[email protected]>
@deckhouse-BOaTswain
Copy link
Contributor

Cherry pick PR 1328 to the branch release-0.24 successful!

loktev-d pushed a commit that referenced this pull request Aug 14, 2025
…tatus (#1256)

This PR introduces a new Exporting phase to the VirtualDisk resource, along with updated InUse and Ready conditions. These changes improve visibility into the state of the disk and prevent accidental usage during data export.
Signed-off-by: Yaroslav Borbat <[email protected]>
Signed-off-by: Daniil Loktev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants