Skip to content

fix(cli): refactor console and vnc for better consistency #1290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 4, 2025
Merged

fix(cli): refactor console and vnc for better consistency #1290

merged 3 commits into from
Aug 4, 2025

Conversation

danilrwx
Copy link
Contributor

@danilrwx danilrwx commented Jul 30, 2025 •
edited
Loading

Description

Rewrite VNC and Console for consistent behavior and code structure. Also fixes some bugs in both.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: cli
type: fix
summary: Rewrite VNC and Console for consistent behavior and code structure. 
impact_level: low

@danilrwx danilrwx added this to the v0.24.0 milestone Jul 30, 2025
@danilrwx danilrwx marked this pull request as ready for review July 30, 2025 08:25
@danilrwx danilrwx requested review from fl64 and Isteb4k as code owners July 30, 2025 08:25
@danilrwx danilrwx force-pushed the fix/cli/vnc-reconnect branch 2 times, most recently from d023b24 to cb02c4b Compare July 30, 2025 18:29
@danilrwx danilrwx force-pushed the fix/cli/vnc-reconnect branch from cb02c4b to bb9e8b7 Compare July 30, 2025 18:29
@danilrwx danilrwx requested a review from yaroslavborbat July 31, 2025 12:03
@danilrwx danilrwx merged commit bfb5180 into main Aug 4, 2025
26 of 27 checks passed
@danilrwx danilrwx deleted the fix/cli/vnc-reconnect branch August 4, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaroslavborbat yaroslavborbat yaroslavborbat approved these changes

@fl64 fl64 Awaiting requested review from fl64 fl64 is a code owner

@Isteb4k Isteb4k Awaiting requested review from Isteb4k Isteb4k is a code owner

Assignees

@danilrwx danilrwx

Labels
None yet
Projects
None yet
Milestone
v0.24.0
Development

Successfully merging this pull request may close these issues.
2 participants
@danilrwx @yaroslavborbat