Skip to content

Conversation

yaroslavborbat
Copy link
Member

@yaroslavborbat yaroslavborbat commented Jul 31, 2025

Description

  • GC will run every day at 00:00.
  • GC will delete all VMOPs in completed state if their TTL has expired (24 hours).
  • GC will delete VMOPs in completed state even if their TTL has not expired, provided there are more than 10 such VMOPs, keeping only the latest 10.

Why do we need it, and what problem does it solve?

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: core
type: chore
summary: refactor GC.
impact_level: low

@yaroslavborbat yaroslavborbat added this to the v0.24.0 milestone Jul 31, 2025
@universal-itengineer universal-itengineer modified the milestones: v0.24.0, v0.25.0 Aug 8, 2025
@yaroslavborbat yaroslavborbat force-pushed the refactor/imrove-gc branch 2 times, most recently from 644a991 to 940be95 Compare August 14, 2025 08:35
@yaroslavborbat yaroslavborbat marked this pull request as ready for review August 14, 2025 08:36
@yaroslavborbat yaroslavborbat requested a review from fl64 as a code owner August 14, 2025 13:02
@yaroslavborbat yaroslavborbat force-pushed the refactor/imrove-gc branch 4 times, most recently from 1b7bf4b to af8e807 Compare August 25, 2025 10:06
@yaroslavborbat yaroslavborbat requested a review from diafour August 25, 2025 10:06
Signed-off-by: Yaroslav Borbat <[email protected]>
@yaroslavborbat yaroslavborbat force-pushed the refactor/imrove-gc branch 2 times, most recently from 195f5fc to 0f2872f Compare August 27, 2025 09:35
@yaroslavborbat yaroslavborbat requested a review from diafour August 27, 2025 09:35
Copy link
Member

@diafour diafour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, run e2e just to be sure ..

@yaroslavborbat yaroslavborbat merged commit 7d92bd4 into main Aug 27, 2025
26 of 27 checks passed
@yaroslavborbat yaroslavborbat deleted the refactor/imrove-gc branch August 27, 2025 13:14
nevermarine pushed a commit that referenced this pull request Aug 27, 2025
GC will run every day at 00:00.
GC will delete all VMOPs in completed state if their TTL has expired (24 hours).
GC will delete VMOPs in completed state even if their TTL has not expired, provided there are more than 10 such VMOPs, keeping only the latest 10.
---------

Signed-off-by: Yaroslav Borbat <[email protected]>
Signed-off-by: Yaroslav Borbat <[email protected]>
Co-authored-by: Ivan Mikheykin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants