-
Notifications
You must be signed in to change notification settings - Fork 2
refactor: improve gc #1292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
refactor: improve gc #1292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6236497
to
b13757e
Compare
644a991
to
940be95
Compare
bd7dfbb
to
061a4bf
Compare
1b7bf4b
to
af8e807
Compare
diafour
reviewed
Aug 26, 2025
images/virtualization-artifact/pkg/controller/gc/cron_source.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Yaroslav Borbat <[email protected]>
195f5fc
to
0f2872f
Compare
07f928a
to
5b51f9e
Compare
Co-authored-by: Ivan Mikheykin <[email protected]> Signed-off-by: Yaroslav Borbat <[email protected]>
4baa4a5
to
3227e09
Compare
diafour
approved these changes
Aug 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, run e2e just to be sure ..
nevermarine
pushed a commit
that referenced
this pull request
Aug 27, 2025
GC will run every day at 00:00. GC will delete all VMOPs in completed state if their TTL has expired (24 hours). GC will delete VMOPs in completed state even if their TTL has not expired, provided there are more than 10 such VMOPs, keeping only the latest 10. --------- Signed-off-by: Yaroslav Borbat <[email protected]> Signed-off-by: Yaroslav Borbat <[email protected]> Co-authored-by: Ivan Mikheykin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Why do we need it, and what problem does it solve?
What is the expected result?
Checklist
Changelog entries