-
Notifications
You must be signed in to change notification settings - Fork 2
fix(module): base64 encoding for custom certificate Secret template #1297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
diafour
merged 2 commits into
main
from
fix/module/global-custom-certificate-patch-secret-problem
Aug 4, 2025
Merged
fix(module): base64 encoding for custom certificate Secret template #1297
diafour
merged 2 commits into
main
from
fix/module/global-custom-certificate-patch-secret-problem
Aug 4, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Mikheykin <[email protected]>
universal-itengineer
previously approved these changes
Jul 31, 2025
Signed-off-by: Ivan Mikheykin <[email protected]>
universal-itengineer
approved these changes
Aug 4, 2025
Tested in cluster with global self-signed certificate and VirtualImage type Upload:
|
Merged
/backport v0.23.1 |
github-actions bot
pushed a commit
that referenced
this pull request
Aug 4, 2025
…1297) * fix(module): base64 encoding for custom certificate Secret template --------- Signed-off-by: Ivan Mikheykin <[email protected]>
deckhouse-BOaTswain
added a commit
that referenced
this pull request
Aug 4, 2025
…template (#1308) fix(module): base64 encoding for custom certificate Secret template (#1297) * fix(module): base64 encoding for custom certificate Secret template --------- Signed-off-by: Ivan Mikheykin <[email protected]> Co-authored-by: Ivan Mikheykin <[email protected]>
Cherry pick PR 1308 to the branch release-0.23 successful! |
This was referenced Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Override helm_lib_module_https_copy_custom_certificate template from the helm-lib, add base64 for Secret fields.
Why do we need it, and what problem does it solve?
Fix of regression after rewrite copy_custom_certificate in Go. helm-lib expects base64 encoded certificates in values, but common hook returns raw strings.
Custom certificate specified in ModuleConfig/global in spec.settings.modules.https.customCertificate.secretName leads to this error:
What is the expected result?
Checklist
Changelog entries