chore(core): refactor cron source #1663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loktev-d
previously approved these changes
Nov 6, 2025
diafour
force-pushed
the
chore/core/refactor-cron-source-to-be-more-universal
branch
from
d163e43 to
202a803
Compare
- Make cron source independent of the garbage collection manager. Signed-off-by: Ivan Mikheykin <[email protected]>
diafour
force-pushed
the
chore/core/refactor-cron-source-to-be-more-universal
branch
from
202a803 to
520895f
Compare
Isteb4k
requested changes
Nov 11, 2025
| clock: &clock.RealClock{}, | ||
| schedule: schedule, | ||
| objLister: objLister, | ||
| log: log.With("WatchSource", sourceName), |
Contributor
There was a problem hiding this comment.
camelCase: log.With("watchSource", ...
Signed-off-by: Ivan Mikheykin <[email protected]>
loktev-d
approved these changes
Nov 11, 2025
Isteb4k
approved these changes
Nov 11, 2025
diafour
deleted the
chore/core/refactor-cron-source-to-be-more-universal
branch
danilrwx
pushed a commit
that referenced
this pull request
Nov 11, 2025
* chore(core): refactor cron source - Make cron source independent of the garbage collection manager. Signed-off-by: Ivan Mikheykin <[email protected]>
danilrwx
pushed a commit
that referenced
this pull request
Nov 11, 2025
* chore(core): refactor cron source - Make cron source independent of the garbage collection manager. Signed-off-by: Ivan Mikheykin <[email protected]>
danilrwx
pushed a commit
that referenced
this pull request
Nov 11, 2025
* chore(core): refactor cron source - Make cron source independent of the garbage collection manager. Signed-off-by: Ivan Mikheykin <[email protected]> Signed-off-by: Daniil Antoshin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Why do we need it, and what problem does it solve?
Cron source may be used for other purposes than garbage collection.
What is the expected result?
Checklist
Changelog entries