Skip to content

Conversation

@hardcoretime
Copy link
Contributor

@hardcoretime hardcoretime commented Nov 8, 2025

Description

Why do we need it, and what problem does it solve?

Sometimes, when the virtual disk snapshot controller creates a batch of snapshots with required consistency, a race condition in the freeze or unfreeze filesystem operation can cause an inconsistent snapshot. To prevent this, the KubeVirt virtual machine instance is now annotated with a "freeze" or "unfreeze" request, and the service checks that the type of this request matches the fsFreezeStatus. The fsFreezeStatus is considered trusted only if it matches the request type.

What is the expected result?

Snapshots with required consistency now execute without race conditions in the filesystem freeze process.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: vdsnapshot
type: fix
summary: "Snapshots with required consistency now execute without race conditions in the filesystem freeze process."

@hardcoretime hardcoretime added this to the v1.2.0 milestone Nov 8, 2025
@hardcoretime hardcoretime force-pushed the fix/vdsnapshot/freeze-request-race-condition branch 11 times, most recently from 1e50463 to 6918581 Compare November 13, 2025 00:35
@hardcoretime hardcoretime force-pushed the fix/vdsnapshot/freeze-request-race-condition branch from 6918581 to 04b73ba Compare November 13, 2025 12:07
Roman Sysoev added 2 commits November 13, 2025 17:06
Signed-off-by: Roman Sysoev <[email protected]>
Signed-off-by: Roman Sysoev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants