Fix/logger #148
Merged
Fix/logger #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
shreyasvinaya
left a comment
shreyasvinaya
left a comment
There was a problem hiding this comment.
potential minor issue with traceback not defined, if it works with the code as is, we can merge
| print(e) | ||
| print(f"ERROR in retrosynthesis:") | ||
| print(f" EXCEPTION: {str(e)}") | ||
| print(f" TRACEBACK: {traceback.format_exc()}") |
Collaborator
There was a problem hiding this comment.
please make sure this works as traceback is not defined anywhere
Collaborator
Author
There was a problem hiding this comment.
This works as is, imported at file start
| print(e) | ||
| print(f"ERROR in rerun_retrosynthesis:") | ||
| print(f" EXCEPTION: {str(e)}") | ||
| print(f" TRACEBACK: {traceback.format_exc()}") |
Collaborator
There was a problem hiding this comment.
similar potential issue here with traceback not defined
Collaborator
Author
There was a problem hiding this comment.
This works as is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #(issue)
Type of change
Please check the option that is related to your PR.
Checklist