Skip to content

Conversation

@redrodeo03
Copy link
Collaborator

Description

Fix #(issue)

Type of change

Please check the option that is related to your PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
    • In this case, we recommend to discuss your modification on GitHub issues before creating the PR
  • Documentations (modification for documents)

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

Copy link
Collaborator

@shreyasvinaya shreyasvinaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to add tests to make sure the original functionality matches the tracing code + add missing files

import csv
from pathlib import Path

INPUT_PATH = Path("data/checker_dataset_pistachio.jsonl")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jsonl file missing in PR

from pathlib import Path

INPUT_PATH = Path("data/checker_dataset_pistachio.jsonl")
OUTPUT_PATH = Path("data/checker_dataset_clean.csv")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CSV file missing in PR

@@ -0,0 +1,274 @@
"""Offline runner to collect rule-based checker data over a SMILES dataset.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add tests to this to make sure the functionality matches the original code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants