51 improve redirects #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

samayer12 merged 4 commits into main from 51-fix-conditional-on-404

Oct 8, 2025

Contributor

AmberFryar commented Oct 6, 2025 •

edited

Loading

Add Netlify _redirects so that the retired versions redirect to the 'latest' version. Improved 404 conditional statement for version strategy if retired version number is in URL. Added testing.

AmberFryar added 2 commits

October 6, 2025 12:17


          chore: new redirect strategy for retired versions

d0b5a25


          chore: added testing

caf5307

AmberFryar linked an issue

that may be closed by this pull request

fix conditional on 404 #51

Closed

samayer12 reviewed

View reviewed changes

.gitignore Show resolved Hide resolved

samayer12 reviewed

View reviewed changes

redirects.js Show resolved Hide resolved

samayer12 reviewed

View reviewed changes

build/version-discovery.mjs Show resolved Hide resolved

samayer12 reviewed

View reviewed changes

build/tests/version-discovery.test.mjs Show resolved Hide resolved

samayer12 reviewed

View reviewed changes

build/tests/version-discovery.test.mjs Outdated Show resolved Hide resolved

samayer12 reviewed

View reviewed changes

build/tests/version-discovery.test.mjs Outdated Show resolved Hide resolved

samayer12 reviewed

View reviewed changes

build/tests/version-discovery-table.test.mjs Outdated Show resolved Hide resolved

samayer12 reviewed

View reviewed changes

build/tests/version-discovery-table.test.mjs Outdated Show resolved Hide resolved

samayer12 reviewed

View reviewed changes

build/tests/retired-redirects.test.mjs Show resolved Hide resolved

samayer12 requested changes

View reviewed changes

Contributor

samayer12 left a comment

For posterity's sake, lets put additional detail into either the PR body or the original issue so we know what sort of problem was solved by this PR.

AmberFryar added 2 commits

October 8, 2025 10:15


          chore: adjusted for code review comments

6d2e3e4


          chore: deleted version test in table format

ffca47d

AmberFryar changed the title ~~51 fix conditional on 404~~ 51 improve redirects

samayer12 approved these changes

View reviewed changes

Contributor

samayer12 left a comment

Good changes following initial review. Thanks!

samayer12 merged commit a1a1d9e into main

5 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet