Skip to content

validate input, and support up to PHP_INT_MAX with GMP/BCMath #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

validate input, and support up to PHP_INT_MAX with GMP/BCMath #12

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
526ebc5
validate input, and support up to PHP_INT_MAX with GMP/BCMath
divinity76 Nov 1, 2016
ae27df5
0 scale for bcdiv
divinity76 Nov 2, 2016
b7111ca
don't mention upgrade size in 32bit php, because 0x7FFFFFFF is max.
divinity76 Nov 2, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 24 additions & 2 deletions PHP/ShortURL.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,33 @@ class ShortURL {
const BASE = 51; // strlen(self::ALPHABET)

public static function encode($num) {
$str = '';
static $mode=-1;
if($mode===-1){
if(is_callable('gmp_div_q')){
$mode=1;
}elseif(is_callable('bcdiv')){
$mode=2;
} else {
$mode=0;
}
}
if(!is_int($num) || $num<1 || ($mode===0 && $num>0x7FFFFFFF)){
throw new InvalidArgumentException('argument 1 MUST be an int between 1 and '.(($mode!==0 || PHP_INT_MAX===0x7FFFFFFF)?PHP_INT_MAX:0x7FFFFFFF.' (PS, if you install the GMP or BCMath extensions, the limit will be upgraded to '.PHP_INT_MAX.')'));
}

$str = '';
while ($num > 0) {
$str = self::ALPHABET[($num % self::BASE)] . $str;
$num = (int) ($num / self::BASE);
if($num<=0x7FFFFFFF)
{
$num = (int) ($num / self::BASE);
} elseif($mode===1) {
$num=gmp_intval(gmp_div_q($num,self::BASE));
} elseif($mode===2){
$num=(int)bcdiv($num,SELF::BASE,0);
}else {
throw new LogicException('unreachable code reached!');
}
}

return $str;
Expand Down