[Spark] Add assertion to verify CDC commit atomicity in streaming #5533
+22
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a deltaAssert to ensure CDC commits are processed atomically in streaming - either all files from a commit are admitted or none at all. This prevents update_preimage and update_postimage rows from being split across separate batches, which would break CDC semantics. Add ProcessAllAvailable() call to prevent race conditions in schema change tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
Add a
deltaAssertto ensure CDC commits are processed atomically in streaming - either all files from a commit are admitted or none at all. This prevents update_preimage and update_postimage rows from being split across separate batches, which would break CDC semantics.Add ProcessAllAvailable() call to prevent race conditions in schema change tests.
How was this patch tested?
Via the tests in
DeltaCDCStreamSuite.Does this PR introduce any user-facing changes?
No