[Kernel][Kernel UC] Make startBoundary required for CommitRange #5537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allisonport-db
requested review from
huan233usc,
raveeram-db and
scottsand-db
scottsand-db
reviewed
Dec 2, 2025
|
|
||
| test("loadCommitRange loads with default boundaries (start=0, end=latest)") { | ||
| testLoadCommitRange(expectedStartVersion = 0, expectedEndVersion = 2) | ||
| test("loadCommitRange throws when no start boundary is provided") { |
Collaborator
There was a problem hiding this comment.
Dah -- this poor pass through API, eh :/
scottsand-db
approved these changes
Dec 2, 2025
raveeram-db
approved these changes
Dec 3, 2025
allisonport-db
added a commit
to allisonport-db/delta
that referenced
this pull request
Dec 5, 2025
…a-io#5537) <!-- Thanks for sending a pull request! Here are some tips for you: 1. If this is your first time, please read our contributor guidelines: https://github.com/delta-io/delta/blob/master/CONTRIBUTING.md 2. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP] Your PR title ...'. 3. Be sure to keep the PR description updated to reflect all changes. 4. Please write your PR title to summarize what this PR proposes. 5. If possible, provide a concise example to reproduce the issue for a faster review. 6. If applicable, include the corresponding issue number in the PR title and link it in the body. --> #### Which Delta project/connector is this regarding? <!-- Please add the component selected below to the beginning of the pull request title For example: [Spark] Title of my pull request --> - [ ] Spark - [ ] Standalone - [ ] Flink - [X] Kernel - [ ] Other (fill in here) ## Description Currently when building a commit range start boundary is optional and defaults to 0 when not provided. However, there is no good use-case during which the start version is not provided so this PR makes it required. The prior behavior can always be implemented by the caller by providing version=0 start boundary. ## How was this patch tested? Updates/adds tests. (cherry picked from commit 9357c6f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
Currently when building a commit range start boundary is optional and defaults to 0 when not provided. However, there is no good use-case during which the start version is not provided so this PR makes it required. The prior behavior can always be implemented by the caller by providing version=0 start boundary.
How was this patch tested?
Updates/adds tests.