[SPARK] Refactor Vacuum code #5557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GH-JamesD
approved these changes
Nov 21, 2025
rajeshparangi
force-pushed
the
rajeshparangi/vacuum_refactor_2
branch
3 times, most recently
from
ebd8875 to
41a62c7
Compare
itsbilal
approved these changes
Nov 24, 2025
Contributor
itsbilal
left a comment
itsbilal
left a comment
There was a problem hiding this comment.
Good with merging this; test failure is in a known flaky test and is unrelated to this change.
zachschuermann
approved these changes
Nov 24, 2025
Member
|
@itsbilal , can we please fix/disable the flaky test asap. it's not good hygiene to be disabling required tests for merge (not to mention that github makes it quite annoying to do so) |
rajeshparangi
force-pushed
the
rajeshparangi/vacuum_refactor_2
branch
from
1592f91 to
4748c24
Compare
zikangh
pushed a commit
to zikangh/delta
that referenced
this pull request
Nov 26, 2025
#### Which Delta project/connector is this regarding - [X] Spark - [ ] Standalone - [ ] Flink - [ ] Kernel - [ ] Other (fill in here) ## Description This PR refactors Vacuum code a bit to be bit more extensible in the future. ## How was this patch tested? Existing tests ## Does this PR introduce _any_ user-facing changes? NO
TimothyW553
pushed a commit
to TimothyW553/delta
that referenced
this pull request
Dec 2, 2025
#### Which Delta project/connector is this regarding - [X] Spark - [ ] Standalone - [ ] Flink - [ ] Kernel - [ ] Other (fill in here) ## Description This PR refactors Vacuum code a bit to be bit more extensible in the future. ## How was this patch tested? Existing tests ## Does this PR introduce _any_ user-facing changes? NO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding
Description
This PR refactors Vacuum code a bit to be bit more extensible in the future.
How was this patch tested?
Existing tests
Does this PR introduce any user-facing changes?
NO