[Kernel] [UC] Handle UC now returning maxCatalogVersion 0 for a newly created table #5570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottsand-db
changed the title
scottsand-db
commented
Nov 24, 2025
| * As of this writing, UC catalog service is not informed when 0.json is successfully written | ||
| * during table creation. Thus, when 0.json exists, the max ratified version returned by UC is -1. | ||
| */ | ||
| private long getTrueUCTableVersion(String ucTableId, long maxRatifiedVersion) { |
Collaborator
Author
There was a problem hiding this comment.
This is the only real change here. Everything else is just test refactors. Thought I'd bundle them all together since it's a rather small PR
scottsand-db
commented
Nov 24, 2025
|
|
||
| val result0 = ucCatalogManagedClient | ||
| .buildCreateTableTransaction("ucTableId", tablePath, testSchema, "test-engine") | ||
| .buildCreateTableTransaction("testUcTableId", tablePath, testSchema, "test-engine") |
Collaborator
Author
There was a problem hiding this comment.
also rename to testUcTableId for clarity; and to align with other test suites
scottsand-db
force-pushed
the
stack/kernel_uc_returns_max_ratified_version_0_after_create
branch
from
08a00b4 to
6501575
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥞 Stacked PR
Use this link to review incremental changes.
Which Delta project/connector is this regarding?
Description
UC now returns 0 as the maxCatalogVersion for newly created tables, instead of -1.
This PR removes code that handled such cases (mapping -1 to the "true" version of 0).
While we're at it, also does some minor test cleanup and refactors.
How was this patch tested?
Minor logic change. Updated existing UTs.
Does this PR introduce any user-facing changes?
No.