[Spark] Move numTargetRowsInserted metric to a filter in insert-only merge #5575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZiyaZa
changed the title
andreaschat-db
approved these changes
Nov 25, 2025
Contributor
andreaschat-db
left a comment
andreaschat-db
left a comment
There was a problem hiding this comment.
LGTM. Thank you for fixing this.
zachschuermann
approved these changes
Nov 25, 2025
zikangh
pushed a commit
to zikangh/delta
that referenced
this pull request
Nov 26, 2025
…merge (delta-io#5575) #### Which Delta project/connector is this regarding? - [x] Spark - [ ] Standalone - [ ] Flink - [ ] Kernel - [ ] Other (fill in here) ## Description This PR moves the `numTargetRowsInserted` metric to a filter in `InsertOnlyMergeExecutor` to make it resistant to pruning. ## How was this patch tested? There are existing unit-tests for the value of this metric. ## Does this PR introduce _any_ user-facing changes? No.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
This PR moves the
numTargetRowsInsertedmetric to a filter inInsertOnlyMergeExecutorto make it resistant to pruning.How was this patch tested?
There are existing unit-tests for the value of this metric.
Does this PR introduce any user-facing changes?
No.