-
Notifications
You must be signed in to change notification settings - Fork 25
Docs cleanup and refinement - in progress #223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…s/conf.py for correct building of Sphinx documentation
|
Thanks for the PR @silentpills , we appreciate it! Currently we are using conda and the environment.yml file to setup our CI/CD pipeline, specifically to run unit tests with pytest. We also get coverage and flake8 runs out the environment, although these are currently informational rather than operational. I'm open to us phasing out conda in favor of pixi if it makes sense for us to do so, but at a minimum we would need to maintain running of unit tests on commits and PRs, and ideally would be be able to keep coverage as well. The workflow we're using is in .github/workflows/python-package-conda.yml ; feel free to update this PR with an updated pixi github action workflow that maintains tests, and I'll take a look ahead of getting this merged. |
…ngle source & moved front_dir and backend_dir into a single web directory
|
Sure! Not a problem at all. I was probably a bit hasty in removing the Conda environment - sorry! I'll take a look at the GitHub workflows you have and make a stab at an alternate action that maintains tests. No harm in maintaining both workflows, though I must say, I think you'll like the speed of Pixi (with uv under the hood)! |
|
Hello @silentpills, Thank you very much for all the work you have done. Before you continue working on this, lets talk about what we can and cannot do now. For example, we cannot move the web-ui branch (and its associated documentation / config files) and it will have to stay as is for now. This is mainly because there are other people working on this remotely and I don't want to disturb what they are doing. About adding / changing to pixi, we need to look more into this (advantages and drawbacks). Lastly, your comment about removing gnss_data.cfg (in the todo list), please do not work on this (I assume it is a future work thing, but just in case...) because we will not be able to apply it. Restrictions related to how the cluster at Ohio State is setup make the cfg file fundamental for things to work. The cleanup of the old documentation, .idea folder, etc, and adding the wiki to the project we can do. If you want, please reach out by email (see my OSU website) and we can discuss a more formal collaboration and establish priorities. Demián |
Summary
I’m a GAMIT/GLOBK user who is interested in this project for its potential to:
As someone approaching the project from the outside, I found the documentation and setup instructions spread across multiple, occasionally conflicting, sources. For a new user, this makes the setup process more involved than likely intended. This PR is the first step toward consolidating and modernizing the documentation and build process so contributors and end users can get the system running cleanly and efficiently.
Changes in this PR
docsfeature inpixi.tomlwith Sphinx and common extensions (myst-parser,furo,sphinx-copybutton,sphinx-autodoc-typehints, etc.).docs:build,docs:serve, anddocs:linkcheck.pixi installsets up the entire environment.environment.yaml(Conda env definition).setup.cfgandsetup.py(previous Python packaging/build configuration).Rationale
Future work (planned in separate PRs)
web-guibranch (frontend + backend) into the main repository and document its workflow.docs/skeleton and migrate existing guides into it.Notes & Collaboration
environment.yamlalongside Pixi so both workflows are supported.