Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for this #2797
The problem was caused by this JSX code:
docs/_includes/doc.tsx
Lines 70 to 75 in 8707eef
It works correctly when the
jsxoption is set toreact-jsx. But inprecompilemode, the element content is passed twice: once with thedangerouslySetInnerHTMLattribute and again as thechildrenproperty which is an empty string (I'm not sure if this is a bug of Deno or it's the expected behavior).I fixed it in the JSX library by concatenating the content instead of replacing it (here), and it works fine now.
BTW, instead of using the
dangerouslySetInnerHTMLattribute, in Lume it's possible to use the children directly, which is cleaner: