-
Notifications
You must be signed in to change notification settings - Fork 27
Add Linux Foundation trademark statement in footer #239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add Linux Foundation trademark statement in footer #239
Conversation
Signed-off-by: Michael Valdron <[email protected]>
4041f87
to
78eb209
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, do you have any screenshots of the new footer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Has point n.6 of the guideline being implemented?
|
Signed-off-by: Michael Valdron <[email protected]>
…ation@a5be632 Signed-off-by: Michael Valdron <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
@l0rd I've included the missing required bottom section of the landing page to mention we're a CNCF sandbox project 62acbb4: ![]() ![]() Let me know how this looks. |
Also have included the revised footer content (cncf/foundation@a5be632) that was specified recently ae21e5f: ![]() ![]() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks great. Thank you @michael-valdron.
Signed-off-by: Michael Valdron <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ibuziuk, Jdubrick, l0rd, michael-valdron The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of Changes
Adds Linux Foundation trademark statement to the landing page and registry viewer page footers for CNCF on-boarding requirements. This will update the footers of devfile.io, registry.devfile.io, and registry.stage.devfile.io websites to meet the requirement.
Related Issue(s)
resolves devfile/api#1736
Acceptance Criteria
Update the sidebar if there is a new file added or an existing filename is changed
Tests Performed
Explain what tests you personally ran to ensure the changes are functioning as expected.
How To Test
Instructions for the reviewer on how to test your changes.
Notes To Reviewer
Any notes you would like to include for the reviewer.