Skip to content

Add Linux Foundation trademark statement in footer #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

michael-valdron
Copy link
Member

Description of Changes

Adds Linux Foundation trademark statement to the landing page and registry viewer page footers for CNCF on-boarding requirements. This will update the footers of devfile.io, registry.devfile.io, and registry.stage.devfile.io websites to meet the requirement.

Related Issue(s)

resolves devfile/api#1736

Acceptance Criteria

  • Unit Tests
  • E2E Tests
  • Documentation
    Update the sidebar if there is a new file added or an existing filename is changed

Tests Performed

Explain what tests you personally ran to ensure the changes are functioning as expected.

How To Test

Instructions for the reviewer on how to test your changes.

Notes To Reviewer

Any notes you would like to include for the reviewer.

@michael-valdron michael-valdron requested review from l0rd, ibuziuk, elsony and a team July 11, 2025 20:03
@openshift-ci openshift-ci bot requested a review from Jdubrick July 11, 2025 20:03
@michael-valdron michael-valdron force-pushed the add-lf-trademark-statement branch from 4041f87 to 78eb209 Compare July 11, 2025 20:06
Copy link
Contributor

@Jdubrick Jdubrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, do you have any screenshots of the new footer?

@michael-valdron
Copy link
Member Author

looks good, do you have any screenshots of the new footer?

Screenshot From 2025-07-15 09-09-55 Screenshot From 2025-07-15 09-10-09 Screenshot From 2025-07-15 09-10-50

Copy link
Contributor

@Jdubrick Jdubrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@l0rd
Copy link
Contributor

l0rd commented Jul 20, 2025

Has point n.6 of the guideline being implemented?

Sandbox-level projects should include the sentence “We are a Cloud Native Computing Foundation sandbox project.” and the CNCF logo. We also appreciate a link to KubeCon + CloudNativeCon as the events approach.

@openshift-ci openshift-ci bot removed the lgtm label Jul 21, 2025
@michael-valdron
Copy link
Member Author

Has point n.6 of the guideline being implemented?

Sandbox-level projects should include the sentence “We are a Cloud Native Computing Foundation sandbox project.” and the CNCF logo. We also appreciate a link to KubeCon + CloudNativeCon as the events approach.

@l0rd I've included the missing required bottom section of the landing page to mention we're a CNCF sandbox project 62acbb4:

Screenshot From 2025-07-21 11-52-00 Screenshot From 2025-07-21 12-04-01

Let me know how this looks.

@michael-valdron
Copy link
Member Author

Also have included the revised footer content (cncf/foundation@a5be632) that was specified recently ae21e5f:

Screenshot From 2025-07-21 12-07-34 Screenshot From 2025-07-21 12-06-59

Copy link
Contributor

@l0rd l0rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great. Thank you @michael-valdron.

@openshift-ci openshift-ci bot removed the lgtm label Jul 21, 2025
@michael-valdron michael-valdron requested a review from Jdubrick July 21, 2025 16:36
Copy link
Contributor

@Jdubrick Jdubrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci openshift-ci bot added the lgtm label Jul 21, 2025
Copy link

openshift-ci bot commented Jul 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ibuziuk, Jdubrick, l0rd, michael-valdron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Jdubrick,michael-valdron]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fulfill the CNCF project on-boarding website requirement
4 participants