Skip to content

chore (deps) : Update controller runtime to v0.21.1-0.20250617162058-15c5d6129278 #1463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rohanKanojia
Copy link
Member

@rohanKanojia rohanKanojia commented Jul 4, 2025

What does this PR do?

⚠️ This PR updates go version to 1.24, it shouldn't be merged until it's supported in downstream release images

  • Update controller-runtime to v0.21.1-0.20250617162058-15c5d6129278
  • Update controller-gen to v0.18.0
  • Update Go version to 1.24.0

Signed-off-by: Rohan Kumar [email protected]

What issues does this PR fix or reference?

#1413

Is it tested? How?

PR Checklist

  • E2E tests pass (when PR is ready, comment /test v8-devworkspace-operator-e2e, v8-che-happy-path to trigger)
    • v8-devworkspace-operator-e2e: DevWorkspace e2e test
    • v8-che-happy-path: Happy path for verification integration with Che

Copy link

openshift-ci bot commented Jul 4, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@rohanKanojia rohanKanojia changed the title chore (deps) : Update controller runtime to v0.21.1-0.20250617162058-15c5d6129278 ⚠️ chore (deps) : Update controller runtime to v0.21.1-0.20250617162058-15c5d6129278 Jul 4, 2025
@rohanKanojia
Copy link
Member Author

/ok-to-test

@@ -14,7 +14,7 @@
#

# https://access.redhat.com/containers/?tab=tags#/registry.access.redhat.com/ubi9/go-toolset
FROM registry.access.redhat.com/ubi9/go-toolset:1.23.9-1749636489 as builder
FROM registry.access.redhat.com/ubi9/go-toolset:1.24.4-1753853351 as builder

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 2: containerImage not pinned by hash
Remediation tip: pin your Docker image by updating registry.access.redhat.com/ubi9/go-toolset:1.24.4-1753853351 to registry.access.redhat.com/ubi9/go-toolset:1.24.4-1753853351@sha256:3ce6311380d5180599a3016031a9112542d43715244816d1d0eabc937952667b
Click Remediation section below for further remediation help
@@ -15,7 +15,7 @@

# Build the manager binary
# https://access.redhat.com/containers/?tab=tags#/registry.access.redhat.com/ubi9/go-toolset
FROM registry.access.redhat.com/ubi9/go-toolset:1.23.9-1749636489 as builder
FROM registry.access.redhat.com/ubi9/go-toolset:1.24.4-1753853351 as builder

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 2: containerImage not pinned by hash
Remediation tip: pin your Docker image by updating registry.access.redhat.com/ubi9/go-toolset:1.24.4-1753853351 to registry.access.redhat.com/ubi9/go-toolset:1.24.4-1753853351@sha256:3ce6311380d5180599a3016031a9112542d43715244816d1d0eabc937952667b
Click Remediation section below for further remediation help
@rohanKanojia rohanKanojia changed the title ⚠️ chore (deps) : Update controller runtime to v0.21.1-0.20250617162058-15c5d6129278 chore (deps) : Update controller runtime to v0.21.1-0.20250617162058-15c5d6129278 Jul 31, 2025
@rohanKanojia
Copy link
Member Author

/ok-to-test

@rohanKanojia rohanKanojia force-pushed the pr/bump-controller-runtime-0-21-0 branch from 110715c to 8979486 Compare August 7, 2025 04:59
@rohanKanojia
Copy link
Member Author

/ok-to-test

@rohanKanojia
Copy link
Member Author

/ok-to-test

1 similar comment
@rohanKanojia
Copy link
Member Author

/ok-to-test

@rohanKanojia
Copy link
Member Author

/retest

2 similar comments
@rohanKanojia
Copy link
Member Author

/retest

@rohanKanojia
Copy link
Member Author

/retest

@dkwon17
Copy link
Collaborator

dkwon17 commented Aug 7, 2025

/retest

@rohanKanojia rohanKanojia force-pushed the pr/bump-controller-runtime-0-21-0 branch from 2c7ec9b to 0d6160c Compare August 7, 2025 15:59
@rohanKanojia
Copy link
Member Author

/ok-to-test

@dkwon17
Copy link
Collaborator

dkwon17 commented Aug 7, 2025

/retest

@rohanKanojia rohanKanojia marked this pull request as ready for review August 7, 2025 20:05
@dkwon17
Copy link
Collaborator

dkwon17 commented Aug 7, 2025

/retest

@dkwon17
Copy link
Collaborator

dkwon17 commented Aug 8, 2025

The new error is:

Unsupported cluster type 'aws' to collect machine IDs
Copying required artifacts to shared dir
cp: cannot stat '/tmp/installer/auth/kubeconfig': No such file or directory
cp: cannot stat '/tmp/installer/auth/kubeadmin-password': No such file or directory
{"component":"entrypoint","error":"wrapped process failed: exit status 1","file":"sigs.k8s.io/prow/pkg/entrypoint/run.go:84","func":"sigs.k8s.io/prow/pkg/entrypoint.Options.internalRun","level":"error","msg":"Error executing test process","severity":"error","time":"2025-08-08T00:27:33Z"}
error: failed to execute wrapped command: exit status 1

Although, I don't know if this is something under our control

@rohanKanojia rohanKanojia force-pushed the pr/bump-controller-runtime-0-21-0 branch from 0d6160c to 3f20e01 Compare August 8, 2025 05:15
@rohanKanojia
Copy link
Member Author

/ok-to-test

go.mod Outdated
go 1.23.0
go 1.24.0

toolchain go1.24.1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we change it to:

Suggested change
toolchain go1.24.1
toolchain go1.24.4

…15c5d6129278

- Update controller-runtime to v0.21.1-0.20250617162058-15c5d6129278
- Update controller-gen to v0.18.0

Signed-off-by: Rohan Kumar <[email protected]>
…de to v0.21.1-0.20250617162058-15c5d6129278

Signed-off-by: Rohan Kumar <[email protected]>
@rohanKanojia rohanKanojia force-pushed the pr/bump-controller-runtime-0-21-0 branch from 3f20e01 to 610f9ae Compare August 8, 2025 14:28
@rohanKanojia
Copy link
Member Author

/ok-to-test

Copy link

openshift-ci bot commented Aug 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dkwon17, rohanKanojia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Aug 8, 2025
@dkwon17 dkwon17 merged commit 7f7db73 into devfile:main Aug 8, 2025
10 of 11 checks passed
@rohanKanojia rohanKanojia deleted the pr/bump-controller-runtime-0-21-0 branch August 9, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants