Skip to content

Go 1.24 for 2.x stack version #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 24, 2025

Conversation

michael-valdron
Copy link
Member

Description of Changes

Cuts new stack 2.x version for Go stack that provides 1.24 Go version.

Related Issue(s)

Acceptance Criteria

  • Contributing guide

Have you read the devfile registry contributing guide and followed its instructions?

  • Test automation

Does this repository's tests pass with your changes?

  • Documentation

Does any documentation need to be updated with your changes?

  • Check Tools Provider

Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)

Tests Performed

Explain what tests you personally ran to ensure the changes are functioning as expected.

How To Test

Instructions for the reviewer on how to test your changes.

Notes To Reviewer

Any notes you would like to include for the reviewer.

@michael-valdron michael-valdron requested review from a team as code owners July 9, 2025 19:24
@openshift-ci openshift-ci bot requested review from Jdubrick and johnmcollier July 9, 2025 19:24
@openshift-ci openshift-ci bot added the approved label Jul 9, 2025
@thepetk thepetk mentioned this pull request Jul 10, 2025
4 tasks
Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I'll approve once the CI checks are passing

Copy link
Contributor

@Jdubrick Jdubrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci openshift-ci bot added the lgtm Looks good to me label Jul 17, 2025
@openshift-ci openshift-ci bot removed the lgtm Looks good to me label Jul 23, 2025
@michael-valdron michael-valdron requested a review from Jdubrick July 23, 2025 18:49
@michael-valdron
Copy link
Member Author

Hi @devfile/che-team, need a review from one of you 👀

Copy link
Collaborator

@svor svor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

screenshot-catalog_demo_redhat_com-2025_07_24-13_26_27

@openshift-ci openshift-ci bot added the lgtm Looks good to me label Jul 24, 2025
@michael-valdron
Copy link
Member Author

@Jdubrick looks good?

Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Jul 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jdubrick, michael-valdron, svor, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Jdubrick,michael-valdron,thepetk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michael-valdron michael-valdron merged commit e94f699 into devfile:main Jul 24, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Looks good to me
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants