[Devfile #1718] Dynamic paths for devfile tests #624
Conversation
There was a problem hiding this comment.
To address DCO use git commit -s to sign off your commits, you can fix your current commit running: git commit -s --amend && git push -f
I'll ignore the Konflux failure as this is not applicable with a deployment change and I'm working on fixing that currently to unblock all promotion changes as they come.
JslYoon
force-pushed
the
JslYoon-renovate-tests
branch
from
39bccb3 to
177db2b
Compare
There was a problem hiding this comment.
The loop and logic for setting the stackDirs and stacksPath looks identical in check_non_terminating.sh and check_odov3, and is pretty similar in validate_devfile_schemas though I see it has more cases. Is there any way we can consolidate some of this so we don't need to change things in multiple places in the future?
If it isn't possible lmk
Signed-off-by: Michael Valdron <[email protected]> Signed-off-by: Lucas Yoon <[email protected]>
JslYoon
force-pushed
the
JslYoon-renovate-tests
branch
from
177db2b to
004f49c
Compare
|
@Jdubrick just made the changes! |
JslYoon
force-pushed
the
JslYoon-renovate-tests
branch
from
34342cf to
39e2d9d
Compare
There was a problem hiding this comment.
@JslYoon A few things address first.
When suggestions are added I was able to run all three scripts with different cases, great work!
There was a problem hiding this comment.
@JslYoon You'll need to amend all the suggestion commits to have your sign off, suggest looking at using git rebase -i HEAD~9 JslYoon-renovate-tests to make amending easier.
JslYoon
force-pushed
the
JslYoon-renovate-tests
branch
2 times, most recently
from
9705e05 to
cbcab3c
Compare
Signed-off-by: Lucas Yoon <[email protected]>
JslYoon
force-pushed
the
JslYoon-renovate-tests
branch
from
cbcab3c to
c65ea41
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jdubrick, JslYoon, michael-valdron The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of Changes
Added dynamic path to take in different data paths for tests check_odov3.sh, check_non_terminating.sh, and validate_devfile_schemas.sh as per changes to be made for epic devfile/api#1278
Related Issue(s)
Link the GitHub/GitLab/JIRA issues that are related to this PR.
devfile/api#1718
Tests Performed
Explain what tests you personally ran to ensure the changes are functioning as expected.
How To Test
Instructions for the reviewer on how to test your changes.
Notes To Reviewer
Any notes you would like to include for the reviewer.