Update runtime image to Red Hat UBI 9 PHP 8.3 #644
Conversation
|
Hi @sbouchet. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
fix eclipse-che/che#23519 Signed-off-by: Stephane Bouchet <[email protected]>
sbouchet
force-pushed
the
eclipse-che/che/issues/23519
branch
from
1b4296d to
3d10910
Compare
Signed-off-by: Stephane Bouchet <[email protected]>
| targetPort: 8000 | ||
| protocol: https | ||
| image: quay.io/devfile/composer:2.5.8 | ||
| image: quay.io/devfile/universal-developer-image:ubi9-latest |
There was a problem hiding this comment.
If the image is going to be changed - maybe it makes sense to create a new version (2.0.2) + add changes to the stack.yaml file
@thepetk could you take a look please
There was a problem hiding this comment.
@sbouchet @RomanNikitenko I think a new major version (3.0.0) + bump would be best here imo, since the entire image is changed.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ibuziuk, sbouchet The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
konflux check failling with : |
|
the failing test |
|
/ok-to-test |
|
@sbouchet Try a rebase to fix the |
|
New changes are detected. LGTM label has been removed. |
|
also, what about version changes discussed here : #644 (comment) |
|
/ok-to-test |
michael-valdron
left a comment
michael-valdron
left a comment
There was a problem hiding this comment.
@sbouchet Run integration tests (bash .ci/openshift_integration.sh) on my cluster against these changes and got passing ✔️
Once you've addressed my comment under @RomanNikitenko's feedback thread I'll sign off.
Signed-off-by: Stephane Bouchet <[email protected]>
Signed-off-by: Stephane Bouchet <[email protected]>
|
/ok-to-test |
|
@sbouchet: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
4 participants
Description of Changes
Update runtime image to Red Hat UBI 9 PHP 8.3 for php laravel sample
Related Issue(s)
fixes eclipse-che/che#23519
fixes eclipse-che/che#23626
Acceptance Criteria
Have you read the devfile registry contributing guide and followed its instructions?
Does this repository's tests pass with your changes?
Does any documentation need to be updated with your changes?
Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)
Tests Performed
Explain what tests you personally ran to ensure the changes are functioning as expected.
How To Test
Instructions for the reviewer on how to test your changes.
Notes To Reviewer
Any notes you would like to include for the reviewer.