Fix checking target branch and label name. #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found that it is not raised error from merge-branch action when target_branch and label_name are empty strings.
When we set empty strings to the target_branch in yaml file and executed GitHub Actions in the personal repository, the Actions failed.
https://github.com/M-Yamashita01/RubySample/runs/4042641757?check_suite_focus=true
And when we set empty strings to the label_name in yaml file and executed GitHub Actions, the error should have been raised, but the Actions passed it by mistake.
https://github.com/M-Yamashita01/RubySample/runs/4051426151?check_suite_focus=true
Therefore, we fixed them and added rspec gem and tests.