chore: drop nightly toolchain #5979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmattia
added
the
CI_ALL_BAZEL_TARGETS
nmattia
removed
the
CI_ALL_BAZEL_TARGETS
nmattia
force-pushed
the
nm-fuzz-env
branch
2 times, most recently
from
366583f to
96a545f
Compare
basvandijk
approved these changes
Jul 21, 2025
Collaborator
basvandijk
left a comment
basvandijk
left a comment
There was a problem hiding this comment.
Nice simplification!
venkkatesh-sekar
approved these changes
Jul 21, 2025
Member
venkkatesh-sekar
left a comment
venkkatesh-sekar
left a comment
There was a problem hiding this comment.
Awesome, thanks for making this change @nmattia
this drops the nightly toolchain that was used in the fuzzers. Instead, `RUSTC_BOOTSTRAP=1` is set in the fuzzer targets, which has the same effect without requiring the download of a second toolchain. NOTE: This vendors the following upstream patch: bazelbuild/rules_rust#3510
Andrei1998
pushed a commit
that referenced
this pull request
Jul 22, 2025
this drops the nightly toolchain that was used in the fuzzers. Instead, `RUSTC_BOOTSTRAP=1` is set in the fuzzer targets, which has the same effect without requiring the download of a second toolchain. NOTE: This vendors the following upstream patch: bazelbuild/rules_rust#3510
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this drops the nightly toolchain that was used in the fuzzers. Instead,
RUSTC_BOOTSTRAP=1is set in the fuzzer targets, which has the sameeffect without requiring the download of a second toolchain.
NOTE: This vendors the following upstream patch: bazelbuild/rules_rust#3510