Skip to content

Conversation

@mraszyk
Copy link
Contributor

@mraszyk mraszyk commented Nov 1, 2025

This PR fixes the consensus registry version of a PocketIC instance resumed from an existing state: for canister http outcalls to work that registry version must be equal to the latest registry version which was not the case for a PocketIC instance resumed from an existing state (in that case the consensus registry version was equal to the registry version at which the corresponding subnet was created which is not always equal to the latest registry version if there are multiple subnets).

More details:

  • the function check_share_against_context requires the registry version of the canister http outcall share (set to the latest registry version by PocketIC) to match the consensus registry version retrieved from the consensus pool cache set by PocketIC here when loading an existing subnet and here when creating a new subnet;
  • the function make_registry_cup used so far creates a CUP with the registry version at which the corresponding registry key catch_up_package_contents_{subnet_id} was inserted into the registry (the registry version at which the corresponding subnet was created by PocketIC);
  • the function make_registry_cup_from_cup_contents used in this PR creates a CUP with a registry version specified in the function's input parameters which allows PocketIC to use the latest registry version in the CUP.

@github-actions github-actions bot added the fix label Nov 1, 2025
@mraszyk mraszyk marked this pull request as ready for review November 3, 2025 14:42
@mraszyk mraszyk requested review from a team as code owners November 3, 2025 14:42
@mraszyk mraszyk enabled auto-merge November 3, 2025 16:38
@mraszyk mraszyk added this pull request to the merge queue Nov 3, 2025
Merged via the queue into master with commit 270e63b Nov 3, 2025
65 of 66 checks passed
@mraszyk mraszyk deleted the mraszyk/pic-cup-registry-version branch November 3, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants