-
Notifications
You must be signed in to change notification settings - Fork 160
Add behavior when entering recovery words #3471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
New UX: Screen.Recording.2025-11-04.at.14.01.04.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds password masking functionality to the recovery phrase input page to enhance security and privacy when entering recovery words. The implementation includes show/hide toggles for individual inputs and all inputs collectively, along with password manager ignore attributes and lowercase normalization.
Key changes:
- Added password masking for recovery phrase inputs with per-field and global show/hide controls
- Implemented lowercase normalization on input to ensure consistent word validation
- Added password manager ignore attributes to prevent interference
Comments suppressed due to low confidence (1)
src/frontend/src/routes/(new-styling)/recovery-phrase/+page.svelte:138
- Corrected spelling of 'Uses' to 'Users'.
// Uses might paste text with multiple spaces, tabs, or newlines between words.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/frontend/src/routes/(new-styling)/recovery-phrase/+page.svelte
Outdated
Show resolved
Hide resolved
sea-snake
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Motivation
Improve the user experience during entering the recovery phrase.
Changes
This pull request enhances the recovery phrase entry page by improving user privacy and usability. The main changes introduce per-word and global visibility toggling for recovery phrase inputs, enforce lowercase input, and add a "Clear all" option. These updates help protect sensitive information from shoulder surfing and password managers, while making the input process smoother and more intuitive.
Recovery phrase input privacy and usability improvements:
showContentproperty to each recovery word and a globalshowAllstate to control visibility of word inputs. Inputs are now masked by default (typepassword), and can be revealed individually (on focus) or all at once via a "Show all"/"Hide all" toggle.data-lpignore,autocomplete="off", etc.).Tests
Tested locally, see videos attached.