Skip to content

replace deprecated Optional/fold with Prelude.Optional.fold #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

replace deprecated Optional/fold with Prelude.Optional.fold #4

wants to merge 1 commit into from

Conversation

mschwaig
Copy link

TristanCacqueray
TristanCacqueray approved these changes Aug 17, 2021
View reviewed changes
Copy link

@TristanCacqueray TristanCacqueray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively we could use the new merge syntax.

@mschwaig
Copy link
Author

Alternatively we could use the new merge syntax.

Thanks for the review, I appreciate it.

Using the new merge syntax might be nicer, but I will not spend time on that. This PR at least makes the project work out of the box again with recent releases of dhall.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@TristanCacqueray TristanCacqueray TristanCacqueray approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mschwaig @TristanCacqueray