Skip to content

Conversation

@tautschnig
Copy link
Collaborator

It is safe to use these primitives for asserting validity of pointers.

Fixes: #8217, #8199

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • n/a Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

It is safe to use these primitives for asserting validity of pointers.

Fixes: diffblue#8217, diffblue#8199
@codecov
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.22%. Comparing base (a209b44) to head (cfc3277).
Report is 33 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop    #8472    +/-   ##
=========================================
  Coverage    78.22%   78.22%            
=========================================
  Files         1726     1726            
  Lines       189038   189038            
  Branches     18265    18467   +202     
=========================================
  Hits        147874   147874            
  Misses       41164    41164            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

the primitive to pointers that point to within a memory object. For example:
both readable and writeable. The primitives return true if `p` points to a live
object and the object that `p` points into extends to at least `size` more
bytes. Else, an assertion encompassing the primitive will be reported to fail.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it also returns false if p is NULL.

Is there a reason why we don't want to say that this would return a non-deterministic value otherwise?

@celinval celinval removed their assignment Nov 13, 2024
@kroening kroening merged commit 57be2aa into diffblue:develop Nov 18, 2024
38 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a new method to check whether a pointer points to a valid location

3 participants