Skip to content

Conversation

@kroening
Copy link
Collaborator

This adds the multi-ary Boolean operators nand and nor to the SMT2 backend.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 5.55556% with 17 lines in your changes missing coverage. Please review.

Project coverage is 78.93%. Comparing base (fa299c5) to head (10eac1d).
Report is 10 commits behind head on develop.

Files with missing lines Patch % Lines
src/solvers/smt2/smt2_conv.cpp 5.55% 17 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8530      +/-   ##
===========================================
+ Coverage    78.63%   78.93%   +0.29%     
===========================================
  Files         1728     1728              
  Lines       199408   198653     -755     
  Branches     18316    18332      +16     
===========================================
+ Hits        156797   156798       +1     
+ Misses       42611    41855     -756     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This adds the multi-ary Boolean operators nand/nor/xnor to the SMT2 backend.
@kroening kroening changed the title SMT2: implement nand, nor SMT2: implement nand, nor, xnor Dec 17, 2024
@kroening kroening marked this pull request as ready for review December 17, 2024 21:01
@kroening kroening merged commit fb28475 into develop Dec 18, 2024
38 of 41 checks passed
@kroening kroening deleted the smt2-nand-nor branch December 18, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants