verilog_synthesist::current_value can be const

This method can be const by replacing the [] operator on a map that is used
by .find(...).

Author: kroening

src/verilog/verilog_synthesis.cpp

@@ -3404,7 +3404,7 @@ Function: verilog_synthesist::symbol_expr
 
 exprt verilog_synthesist::symbol_expr(
   const symbolt &symbol,
-  curr_or_nextt curr_or_next)
+  curr_or_nextt curr_or_next) const
 {
   exprt result=exprt(curr_or_next==NEXT?ID_next_symbol:ID_symbol, symbol.type);
   result.set(ID_identifier, symbol.name);
@@ -3527,21 +3527,23 @@ Function: verilog_synthesist::current_value
 exprt verilog_synthesist::current_value(
   const value_mapt::mapt &map,
   const symbolt &symbol,
-  bool use_previous_assignments)
+  bool use_previous_assignments) const
 {
   if(!symbol.is_state_var)
   {
     if(use_previous_assignments)
     {
       // see if we have a previous assignment
-      const assignmentt &assignment=assignments[symbol.name];
-      const exprt &value=
-        (construct==constructt::INITIAL)?
-          assignment.init.value:
-          assignment.next.value;
+      auto assignment_it = assignments.find(symbol.name);
+      if(assignment_it != assignments.end())
+      {
+        const exprt &value = (construct == constructt::INITIAL)
+                               ? assignment_it->second.init.value
+                               : assignment_it->second.next.value;
 
-      if(value.is_not_nil())
-        return value; // done
+        if(value.is_not_nil())
+          return value; // done
+      }
     }
 
     return symbol_expr(symbol, CURRENT);
@@ -3557,13 +3559,16 @@ exprt verilog_synthesist::current_value(
     if(use_previous_assignments)
     {
       // see if we have a previous assignment
-      const assignmentt &assignment=assignments[symbol.name];
-      const exprt &value=
-        (construct==constructt::INITIAL)?
-          assignment.init.value:assignment.next.value;
+      auto assignment_it = assignments.find(symbol.name);
+      if(assignment_it != assignments.end())
+      {
+        const exprt &value = (construct == constructt::INITIAL)
+                               ? assignment_it->second.init.value
+                               : assignment_it->second.next.value;
 
-      if(value.is_not_nil())
-        return value; // done
+        if(value.is_not_nil())
+          return value; // done
+      }
     }
 
     if(

src/verilog/verilog_synthesis_class.h

@@ -177,25 +177,25 @@ class verilog_synthesist:
 
     exprt guarded_expr(exprt) const;
   };
-   
+
   exprt current_value(
     const value_mapt::mapt &map,
-    const symbolt &symbol,
-    bool use_previous_assignments);
+    const symbolt &,
+    bool use_previous_assignments) const;
 
   exprt guarded_expr(exprt expr) const
   {
     PRECONDITION(value_map != NULL);
     return value_map->guarded_expr(expr);
   }
 
-  inline exprt current_value(const symbolt &symbol)
+  inline exprt current_value(const symbolt &symbol) const
   {
     PRECONDITION(value_map != NULL);
     return current_value(value_map->current, symbol, false);
   }
 
-  inline exprt final_value(const symbolt &symbol)
+  inline exprt final_value(const symbolt &symbol) const
   {
     PRECONDITION(value_map != NULL);
     return current_value(value_map->final, symbol, true);
@@ -279,9 +279,7 @@ class verilog_synthesist:
 
   typedef enum { CURRENT, NEXT } curr_or_nextt;
 
-  exprt symbol_expr(
-    const symbolt &symbol,
-    curr_or_nextt curr_or_next);
+  exprt symbol_expr(const symbolt &, curr_or_nextt curr_or_next) const;
 
   void extract_expr(exprt &dest, unsigned bit);