Skip to content

Conversation

@Pankraz76
Copy link
Contributor

@Pankraz76 Pankraz76 commented Nov 22, 2025

tryout reduce warnings for:

Please DO NOT FORCE PUSH. Don't worry about messy history, it's easier to do code review if we can tell what happened after the review, and force pushing breaks that.

Please make sure that your PR allows edits from maintainers. Sometimes it's faster for us to just fix something than it is to describe how to fix it.

Allow edits from maintainers

After creating the PR, please add a commit that adds a bullet-point under the [Unreleased] section of CHANGES.md, plugin-gradle/CHANGES.md, and plugin-maven/CHANGES.md which includes:

  • a summary of the change
  • either
    • a link to the issue you are resolving (for small changes)
    • a link to the PR you just created (for big changes likely to have discussion)

If your change only affects a build plugin, and not the lib, then you only need to update the plugin-foo/CHANGES.md for that plugin.

If your change affects lib in an end-user-visible way (fixing a bug, updating a version) then you need to update CHANGES.md for both the lib and all build plugins. Users of a build plugin shouldn't have to refer to lib to see changes that affect them.

This makes it easier for the maintainers to quickly release your changes :)

@Pankraz76 Pankraz76 changed the title [prone] diable warning CollectorMutability, fix warning StaticImport [prone] diable warning CollectorMutability, fix warning MissingOverride Nov 22, 2025
@Pankraz76 Pankraz76 force-pushed the disable-CollectorMutability branch 3 times, most recently from b3628e2 to bdeebe9 Compare November 22, 2025 12:18
}
}

@Override
Copy link
Contributor Author

@Pankraz76 Pankraz76 Nov 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also rewrite, not spotless, ending up being error prone as well completing the circulation.

@Pankraz76 Pankraz76 marked this pull request as ready for review November 22, 2025 12:50
@Pankraz76 Pankraz76 changed the title [prone] diable warning CollectorMutability, fix warning MissingOverride [prone] remove failing tech.picnic.error-prone-support Nov 22, 2025
@Pankraz76 Pankraz76 force-pushed the disable-CollectorMutability branch from bdeebe9 to 2e88ead Compare November 22, 2025 13:07
@Pankraz76 Pankraz76 mentioned this pull request Nov 22, 2025
3 tasks
@Pankraz76 Pankraz76 force-pushed the disable-CollectorMutability branch from 2e88ead to 84d377e Compare November 22, 2025 13:09
@Pankraz76 Pankraz76 force-pushed the disable-CollectorMutability branch from 84d377e to d972573 Compare November 22, 2025 13:15
@Pankraz76
Copy link
Contributor Author

have you updated the github version somehow @nedtwigg ?

Now its keeping the diff even after forbidden force push.

image

Now its seems ready consider suppressing all the warnings.

@Pankraz76 Pankraz76 force-pushed the disable-CollectorMutability branch from d972573 to 6356f50 Compare November 22, 2025 16:25
@Pankraz76
Copy link
Contributor Author

zero warnings as requsted:

image

@nedtwigg nedtwigg merged commit 24a9294 into diffplug:main Nov 22, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants