-
Notifications
You must be signed in to change notification settings - Fork 45
chore: conform project names in monorepo #3532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 653864c The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Preview deployments for this pull request: Storybook - Storefront - Theme - |
Coverage Report
File CoverageNo changed files found. |
|
|
hmm, yeah, not to fan of the underscore either. 🤔
|
I agree with this. Having it under |
|
Also not quite sure why the Figma plugin needs its own top-level |
Bah, why we didn't we think of this before 😂 This approach makes much more sense to me, cleaner naming aswell :) |
We had a brief discussion about it when we added the plugin. The reason we went for that folder is in case we get more plugins later on. |
This will break a lot of PRs now tho 💔 |
This reverts commit 8a014b6.
|
We will break this up into several smaller PRs |
|
Continue in #3559 |
Aimed for short but descriptive names on our projects.
Updated after comments
@webfor stuff under/web@pluginfor stuff under/pluginsinternalfolder for internal stuffstorefrontas this will be removed soon-ishthemeso that we can make the RR7 version using@app/theme@types/reactto latest because some devDependency was messing with@internal/componentstypes and use ofDialogpackage.jsonin biome ignoreRenamedappstoweb(webssounds weird)