Skip to content

Add support for OIDC type tokens. #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add support for OIDC type tokens. #11

wants to merge 1 commit into from

Conversation

dmitrizagidulin
Copy link
Contributor

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #11 (0fa83ee) into master (4241a27) will decrease coverage by 0.10%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
- Coverage   55.96%   55.85%   -0.11%     
==========================================
  Files           2        2              
  Lines         109      111       +2     
==========================================
+ Hits           61       62       +1     
- Misses         48       49       +1     
Impacted Files Coverage Δ
TokenService.js 65.26% <66.66%> (-0.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4241a27...0fa83ee. Read the comment docs.

@mattcollier
Copy link
Contributor

@dmitrizagidulin what is the status of this work. I see that no reviewers were selected for this PR.

@dmitrizagidulin
Copy link
Contributor Author

@mattcollier - so, this was for a very specific point in time (related to svip I think, related to wallet pr 352), and Tashi and I weren't clear on whether it was a one-off demo, or if engineering wanted to add it to our codebase.

@dmitrizagidulin
Copy link
Contributor Author

Update: discussed on the Feb 9 standup, consensus is: we're not going to think about it until mid-april.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants