Skip to content

Fix bug with pbkdf2 expression of salt parameter. #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 16, 2025

Conversation

dlongley
Copy link
Member

No description provided.

Copy link
Member

@davidlehn davidlehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to add a short test to avoid future regressions for this. But that requires exposing the internal functions, so maybe not worth it here.

@davidlehn
Copy link
Member

Needs codecov token in the workflow.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.95%. Comparing base (62ddebd) to head (52d29d8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #29   +/-   ##
=======================================
  Coverage   55.95%   55.95%           
=======================================
  Files           3        3           
  Lines         168      168           
=======================================
  Hits           94       94           
  Misses         74       74           
Files with missing lines Coverage Δ
lib/pbkdf2.js 50.81% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62ddebd...52d29d8. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dlongley dlongley merged commit 9e29209 into main Jul 16, 2025
3 checks passed
@dlongley dlongley deleted the fix-base64-encoding branch July 16, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants