Skip to content

Conversation

@magyarblip
Copy link

PR to address issue #54

  • uses standard jsonld-document-loader package
  • I added a .markdownlint doc to make it easier to lint

See https://github.com/magyarblip/test-cborld for a working version, cos READMEs are hard to execute....

Copy link
Contributor

@BigBlueHat BigBlueHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Thanks for fixing that.

@BigBlueHat
Copy link
Contributor

I added a .markdownlint doc to make it easier to lint

Which tool did you use for running the markdown linting? I've found a few, like this one for VS Code which looks to support that config file:
https://marketplace.visualstudio.com/items?itemName=DavidAnson.vscode-markdownlint

Ah. It also looks like there's a Node.js port also: https://github.com/DavidAnson/markdownlint

Fab. This could be helpful across the board for your repos. Much appreciated, @magyarblip!

@magyarblip
Copy link
Author

Yes, https://github.com/DavidAnson/markdownlint is the one i use, mostly cos it has a lot of subscribers and is configurable.

@davidlehn
Copy link
Member

Also note we will (hopefully soon) update to eslint v9 and I had thought of using their new https://github.com/eslint/markdown plugin. That might not be as comprehensive yet though.

@BigBlueHat
Copy link
Contributor

Also note we will (hopefully soon) update to eslint v9 and I had thought of using their new https://github.com/eslint/markdown plugin. That might not be as comprehensive yet though.

And we're still blocked on getting to eslint@9 for that. Merging the config file is harmless and I'm keen to try it out elsewhere. We can always switch to the eslint one if/when all the planets align properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants