Skip to content

Conversation

@posita
Copy link

@posita posita commented Sep 22, 2021

Fixes #18 and #22.
Includes some minor README.md cleanup.

@posita
Copy link
Author

posita commented Sep 22, 2021

Before:

% pre-commit run --verbose --all-files
…
PHP Syntax Check (Comprehensive).........................................Failed
- hook id: php-lint-all
- duration: 7.74s
- exit code: 1

Begin PHP Linter
Begin PHP Linter
Begin PHP Linter
Begin PHP Linter
Begin PHP Linter
────────────────────────────────────────────────────────────────────────────────
2 PHP Parse error(s) were found!
────────────────────────────────────────────────────────────────────────────────
Begin PHP Linter
Begin PHP Linter
────────────────────────────────────────────────────────────────────────────────
1 PHP Parse error(s) were found!
────────────────────────────────────────────────────────────────────────────────
Begin PHP Linter

After:

% pre-commit run --verbose --all-files
…
PHP Syntax Check (Comprehensive).........................................Failed
- hook id: php-lint-all
- duration: 7.74s
- exit code: 1

Begin PHP Linter
Begin PHP Linter
Begin PHP Linter
Begin PHP Linter
Begin PHP Linter
Could not open input file: src/…/HasA
Could not open input file: SpaceInItsName.php
────────────────────────────────────────────────────────────────────────────────
2 PHP Parse error(s) were found!
────────────────────────────────────────────────────────────────────────────────
Begin PHP Linter
Begin PHP Linter

Fatal error: Cannot use "self" when no class scope is active in src/…/foo.php on line 255
Errors parsing src/…/foo.php
────────────────────────────────────────────────────────────────────────────────
1 PHP Parse error(s) were found!
────────────────────────────────────────────────────────────────────────────────
Begin PHP Linter

@posita posita force-pushed the posita/0/print-offending-files branch from 7443c13 to a7940e0 Compare September 29, 2021 20:14
@posita posita changed the title Print offending files with php-lint Print offending files with php-lint and accommodate paths with spaces Sep 29, 2021
Fixes digitalpulp#18 and digitalpulp#22.
Includes some minor `README.md` cleanup.
@posita posita force-pushed the posita/0/print-offending-files branch from a7940e0 to a71d9dd Compare September 30, 2021 03:29
@posita
Copy link
Author

posita commented Feb 1, 2022

Friendly ping. Any interest in landing this?

@posita
Copy link
Author

posita commented May 28, 2022

Any interest, or has this project been abandoned?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

php-lint-all doesn't identify problematic files, only that there were some

1 participant