Skip to content

Discord's application commands should be stored in a Collection #1417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Discord's application commands should be stored in a Collection #1417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e819da8
Update Discord.php
valzargaming Oct 7, 2025
e6a408b
attributeCollectionHelper shouldn't create empty parts
valzargaming Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Discord/Discord.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,7 @@ class Discord
/**
* An array of registered slash commands.
*
* @var RegisteredCommand[]
* @var ExCollectionInterface<RegisteredCommand>|RegisteredCommand[]
*/
protected $application_commands;

Expand Down Expand Up @@ -401,6 +401,7 @@ public function __construct(array $options = [])
$this->token = $options['token'];
$this->loop = $options['loop'];
$this->logger = $options['logger'];
$this->application_commands = Collection::for(RegisteredCommand::class, 'name');

if (! in_array(php_sapi_name(), ['cli', 'micro'])) {
$this->logger->critical('DiscordPHP will not run on a webserver. Please use PHP CLI to run a DiscordPHP bot.');
Expand Down
2 changes: 1 addition & 1 deletion src/Discord/Parts/PartTrait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,7 +470,7 @@ protected function attributeCollectionHelper($key, $class, ?string $discrim = 'i
{
$collection = Collection::for($class, $discrim);

if (! isset($this->attributes[$key])) {
if (empty($this->attributes[$key])) {
return $collection;
}

Expand Down