-
Notifications
You must be signed in to change notification settings - Fork 3
FEATURE: shift to yjs #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SamSaffron
wants to merge
19
commits into
main
Choose a base branch
from
yjs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+12,869
−2,609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes shared edits much more reliable
klappradla
reviewed
Nov 25, 2025
Member
Author
|
no worries, will do
…On Wed, Nov 26, 2025 at 9:16 AM Max Mulatz ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
On db/migrate/20251124000000_resize_shared_edit_columns.rb
<#143 (comment)>
:
Just as a heads up for other people (like me...) super curious to try out
this branch: the timestamp / name of this migration collides with one in
the main discourse repo. So if you adjust this one before hand, maybe by
replacing the last 0 with a 1, you'll have a smoother start 💁
—
Reply to this email directly, view it on GitHub
<#143 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAABIXILX6NMATTELG5RDDD36TIL7AVCNFSM6AAAAACNCBARCOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTKMBXGA4TEMZWHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
show shared edit button unconditionally
Member
Author
|
note... for people reading here, more than happy to get feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes shared edits much more reliable