Add show_toolbar_with_docker function for Docker IP handling #2123
Conversation
- Introduced a new function, show_toolbar_with_docker, to determine if the toolbar should be displayed when running inside Docker containers. - Updated installation documentation to reference the new function for Docker configurations. - Added a changelog entry for the new functionality.
| * Add hook to RedirectsPanel for subclass customization | ||
| * Added ``show_toolbar_with_docker`` function to check Docker host IP address | ||
| when running inside Docker containers. | ||
|
|
There was a problem hiding this comment.
The first entry seems to be a duplicate of something old?
The second entry is good, but it should go up into the "Pending" section.
| @@ -155,7 +155,7 @@ option. | |||
| If using Docker, the toolbar will attempt to look up your host name | |||
| automatically and treat it as an allowable internal IP. If you're not | |||
| able to get the toolbar to work with your docker installation, review | |||
| the code in ``debug_toolbar.middleware.show_toolbar``. | |||
| the code in ``debug_toolbar.middleware.show_toolbar_with_docker``. | |||
There was a problem hiding this comment.
So, that warning has to be reworked. Something like:
"If using Docker you can use debug_toolbar.middleware.show_toolbar_with_docker which attempts to automatically look up the Docker gateway IP and treat it as an allowable internal IP so that the toolbar is shown to you."
|
Hi @blingblin-g |
|
Replaced by #2153 |
|
Oh, Sorry. I just noticed that the PR I was responsible for was closed just now after remaining unfinished for a long time. Could you please let me know if there is anything else that needs to be done regarding this task? And I will make sure to share updates on my progress more frequently and inform you in advance if there are any delays. Thank you. |
|
Hi @blingblin-g Sure, I'd appreciate a review on the new PR over here: #2153 I mostly only applied the suggested changes and submitted it myself again, still with you as the author. |
|
Great! I’d love to review it. |
Description
Fixes #2113
Checklist:
docs/changes.rst.