Fix DeprecationWarnings by updating key type property usage in tests #1590
Conversation
|
@Subham-KRLX for context, can you link to the documentation regarding the deprecation of key_type here in the issue? |
|
Hi @dopry, this change is based on the official JSON Web Key spec (RFC 7517, Section 4.1) which mandates "kty" as the standard parameter for key type. The older key_type property in libraries like jwcrypto has been deprecated and now triggers warnings with .kty being the correct standards-compliant attribute. Updating the tests removes these DeprecationWarnings ensures compatibility with the latest dependencies and aligns with the JWK specification. |
|
I'm familiar with the spec change. I was specifically wondering which one of our dependencies is throwing this deprecation warning and is a mention of the deprecation available in their changelog or release notes. |
dopry
force-pushed
the
fix-deprecation-warnings
branch
from
10a5cbd to
f82bb48
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
The warning comes from the jwcrypto library. |
|
Awesome thanks for digging that up for me! It actually got deprecated in latchset/jwcrypto@0edf66d, https://github.com/latchset/jwcrypto/releases/tag/v0.9.0 |
dopry
force-pushed
the
fix-deprecation-warnings
branch
from
f82bb48 to
74adea0
Compare
|
I think now its good to go. |
Fixes #1483.
Replaced deprecated key.key_type with key.kty in test files to remove DeprecationWarnings and ensure compatibility with latest dependencies.
Single change (remove DeprecationWarnings).